Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage 79.07% 79.07%
=======================================
Files 17 17
Lines 2079 2079
Branches 362 362
=======================================
Hits 1644 1644
Misses 300 300
Partials 135 135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asmacdo
left a comment
asmacdo
left a comment
There was a problem hiding this comment.
Should drop a link to this into https://pennlinc-babs.readthedocs.io/en/stable/developer.html
Overall looks good to me!
| `docs/developer_how_to_test.rst`. | ||
| - Python style: run `ruff check .` and `ruff format --check .`. | ||
| - Shell scripts: run the shellcheck command used by GitHub Actions. | ||
| - Documentation: build with `python -m sphinx -W -b html docs docs/build/html`. |
There was a problem hiding this comment.
Do we need to manually add a changelog entry?
| ruff check . | ||
| ruff format --check . | ||
| ruff check --fix | ||
| ruff format |
There was a problem hiding this comment.
We could shorten this by adding precommit and just referencing that.
|
|
||
| Do not guess project conventions. If a workflow is not documented in | ||
| `CONTRIBUTING.md` or repository files, say so instead of inventing one. |
| ``` | ||
|
|
||
| ## Command Line Entry Points | ||
|
|
There was a problem hiding this comment.
| babs --help |
| The root `Makefile` has targets named `install`, `setup-user`, and `e2e` that | ||
| refer to `tests/e2e-slurm/install-babs.sh`, `tests/e2e-slurm/setup-user.sh`, | ||
| and `tests/e2e-slurm/main.sh`. If those scripts are absent in your checkout, | ||
| those targets will fail. The `clean` target does exist and removes the `slurm` | ||
| container and `.testdata`. |
There was a problem hiding this comment.
That make file hasnt been updated for 2 years, and probably is just "dead". Should we remove it and references?
3 participants
No description provided.