Skip to content

Get container before babs submit if missing#380

Merged
mattcieslak merged 2 commits into
mainfrom
get-container
Jun 10, 2026
Merged

Get container before babs submit if missing#380
mattcieslak merged 2 commits into
mainfrom
get-container

Conversation

@tien-tong

Copy link
Copy Markdown
Contributor

Closes #375. Make babs submit ensure that te configured container images are available before scheduler submission.

Changes:

  • Added submit-time container image check/fetch.
  • Skips datalad get when the image already exists.
  • Fails before job submission if a missing image cannot be retrieved.
  • Stores container_images in new project config, with fallback support for older configs.
  • Removed obsolete manual container datalad get steps from docs, e2e script, and tests.
  • Added tests for fetch, skip, and failure behavior.

@tien-tong tien-tong added the enhancement New feature or request label May 22, 2026
@codecov-commenter

codecov-commenter commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.49%. Comparing base (95fd99d) to head (97983e1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   79.07%   79.49%   +0.41%     
==========================================
  Files          17       17              
  Lines        2079     2121      +42     
  Branches      362      373      +11     
==========================================
+ Hits         1644     1686      +42     
  Misses        300      300              
  Partials      135      135              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattcieslak mattcieslak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice tests and simplifies the e2e workflow

@mattcieslak mattcieslak merged commit 850b06e into main Jun 10, 2026
10 checks passed
@mattcieslak mattcieslak deleted the get-container branch June 10, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add datalad get <container path> to babs submit

3 participants