Draft
Conversation
…ication record, delete all linked Deployment records, and send delete event to Pusher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when an Application is deleted we delete the associated infrastructure as well as the application record in the Applications DynamoDB table. But we leave the application's deployment records in the Deployments DynamoDB table.
This PR fixes this by also deleting all deployment records associated with the deleted application.
It also uses Pusher to send a new event type,
application_deletion_event, on the application's channel to notify the frontend of the application's deletion. This event looks like: