Skip to content

ci: add GitHub Actions workflows; fix merge-marker defects, Q-learnin… - #20

Merged
Pentexa merged 1 commit into
mainfrom
chore/quality-ci
Nov 7, 2026
Merged

Pentexa merged 1 commit into
mainfrom
chore/quality-ci

Conversation

@Pentexa

@Pentexa Pentexa commented Nov 7, 2026

Copy link
Copy Markdown
Owner

…g restore, rust lints; add regression tests

Repository quality and CI pass for METARGON.

Fixes:

  • python/benchmark_v09.py and python/test_benchmark_v09.py contained unresolved merge conflict markers (HEAD vs origin/main) that broke the v0.9 suite at import time. Restored the canonical v0.9 content from fd47b6b; only marker lines and the old origin/main branches removed.
  • academy/agents/baselines.py QLearningPolicy.load_state wrapped saved signatures in an extra tuple, so a reloaded Q-table was unreachable at decision time (silently discarding learning). Keys now rebuild from the saved row directly.
  • rust: fix clippy lints (map_or -> is_none_or; format! capture; scoped borrows in rust_academy memory) so cargo clippy -D warnings passes.
  • README/CONTRIBUTING: document that the Academy layer requires Python 3.11+ (stdlib tomllib) while python/ suites still run on 3.10+; note hash-seed sensitivity of internal Academy bookkeeping.

Tests added:

  • academy/tests/test_agents.py: QLearningPolicy save/load round-trip and committed-policy load regression tests (runtime-reachable keys).
  • python/test_repo_hygiene.py: fails if unresolved merge markers reappear.

CI (.github/workflows/ci.yml): repo hygiene checks, python v0.9 +
historical suite, Academy suite (3.11/3.12) + CLI smoke, and both Rust
crates (test --locked + clippy -D warnings) on pinned 1.88.0 toolchain.
Python jobs pin PYTHONHASHSEED=0 for intra-job determinism.

Known limitations (documented): full Academy eval/ rain runs are slow (Bayes baseline dominates); Academy internal hypothesis bookkeeping is hash-seed sensitive while summary metrics reproduce; cargo fmt is not enforced in CI because the crates are currently not rustfmt-clean.

…g restore, rust lints; add regression tests

Repository quality and CI pass for METARGON.

Fixes:
- python/benchmark_v09.py and python/test_benchmark_v09.py contained
  unresolved merge conflict markers (HEAD vs origin/main) that broke the
  v0.9 suite at import time. Restored the canonical v0.9 content from
  fd47b6b; only marker lines and the old origin/main branches removed.
- academy/agents/baselines.py QLearningPolicy.load_state wrapped saved
  signatures in an extra tuple, so a reloaded Q-table was unreachable at
  decision time (silently discarding learning). Keys now rebuild from the
  saved row directly.
- rust: fix clippy lints (map_or -> is_none_or; format! capture; scoped
  borrows in rust_academy memory) so cargo clippy -D warnings passes.
- README/CONTRIBUTING: document that the Academy layer requires Python
  3.11+ (stdlib tomllib) while python/ suites still run on 3.10+; note
  hash-seed sensitivity of internal Academy bookkeeping.

Tests added:
- academy/tests/test_agents.py: QLearningPolicy save/load round-trip and
  committed-policy load regression tests (runtime-reachable keys).
- python/test_repo_hygiene.py: fails if unresolved merge markers reappear.

CI (.github/workflows/ci.yml): repo hygiene checks, python v0.9 +
  historical suite, Academy suite (3.11/3.12) + CLI smoke, and both Rust
  crates (test --locked + clippy -D warnings) on pinned 1.88.0 toolchain.
  Python jobs pin PYTHONHASHSEED=0 for intra-job determinism.

Known limitations (documented): full Academy eval/	rain runs are slow
(Bayes baseline dominates); Academy internal hypothesis bookkeeping is
hash-seed sensitive while summary metrics reproduce; cargo fmt is not
enforced in CI because the crates are currently not rustfmt-clean.
Copilot AI balanced review requested due to automatic review settings November 7, 2026 19:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@Pentexa
Pentexa merged commit 02421fb into main Nov 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants