Skip to content

ci: skip full checks for draft pull requests - #249

Merged
PerfectPan merged 1 commit into
mainfrom
ci/ready-pr-checks
Nov 3, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
ci/ready-pr-checks

Conversation

@PerfectPan

@PerfectPan PerfectPan commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

Synchronize the Ready-PR CI policy prepared first in project-template #9, project-template-rush #26, and project-template-pnpm #3. Keep this pnpm repository's own validation and release implementation.

  • Add the shared non-Draft guard to the existing check job. Ready PRs run on opened, synchronize, reopened, and ready_for_review; Draft PRs skip the full suite. Preserve the existing main push trigger, job name, read-only permissions, concurrency and every validation step. No manual trigger is added.
  • Preserve the lightweight Review workflow on Draft and metadata events. It checks repository metadata and PR titles/descriptions without installing project dependencies or running the full suite; Bot authors remain exempt only from the description check.
  • Update the contribution/release instructions and a Version Packages comment. Release PRs still use pr-draft: always; closing/reopening a Draft PR does not bypass the guard, and changing token type does not remove it. No executable release behavior or permissions change.
  • Keep this change separate from Dependabot retirement PR chore(deps): retire Dependabot Actions version updates #248; all dependency automation, dependency/lock files, and unrelated workflows remain unchanged. No changeset is needed for CI and documentation only.

Validation

  • gh repo-checks repository and git diff --check — passed.
  • actionlint 1.7.12 on .github/workflows/ci.yml and .github/workflows/version-packages.yml — passed.
  • A 32-case static matrix parsed the actual YAML and evaluated PR events, Draft state, author type, the main push and absent manual-dispatch route. It also checked the retained Review behavior. All cases passed; this is configuration validation, not live GitHub or Renovate delivery evidence.
  • Parsed-YAML comparison confirms only the CI guard changes executable workflow behavior. The Version Packages change is comments only; Review, Publish npm, dependency automation, manifests and lockfile match main byte-for-byte.
  • gh repo-checks pr-title and gh repo-checks pr-body — checked for the prepared title/body before publication.
  • Real Draft observation on final head 76de05c305c895696b72da624f7e834bc4f3bd69: CI 41609207363 skipped check with zero steps, while Draft Review 41609207466 passed all three lightweight checks. The skipped CI job demonstrates the Draft policy; it is not test execution.
  • Marking that unchanged head Ready triggered full CI 41609345261, which passed with check actually executing pnpm run check (format, build, lint, typecheck, tests and package checks). Ready Review 41609345250 also passed all three checks.
  • The Ready run tested merge b9c30256739472a768b0d391837efc7630167a42, combining the then-current main 2b1a2f12b7d19f5d5b3295374715c177ec90cf05 with the final PR head. The hosted aggregate gate used the declared toolchain; the isolated local checkout did not reuse dependencies from another working tree.
  • After squash merge d11379fb050b441141448eef53662c0b85c80eef, main-push CI 41611277160 also passed with the full check job actually executing. These are completed results, separate from the static policy matrix above.

Risks

The read-only protection audit found check and the three Review jobs required, admin enforcement enabled, zero required approvals, and non-strict status checks. Those settings are unchanged. GitHub counts skipped jobs as successful, so confirm an executed successful check on the current head and merge result; a skipped Draft result or an older comparison is insufficient evidence.

GitHub may require maintainer approval for PR events created with GITHUB_TOKEN. This change neither broadens tokens nor modifies account/security settings. It preserves the existing release Draft handoff and main-push validation. No PR is merged or closed by this change.

@PerfectPan
PerfectPan marked this pull request as ready for review November 3, 2026 09:14
@PerfectPan
PerfectPan merged commit d11379f into main Nov 3, 2026
8 checks passed
@PerfectPan
PerfectPan deleted the ci/ready-pr-checks branch November 3, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant