Repository navigation
ci: skip full checks for draft pull requests - #249
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Synchronize the Ready-PR CI policy prepared first in project-template #9, project-template-rush #26, and project-template-pnpm #3. Keep this pnpm repository's own validation and release implementation.
checkjob. Ready PRs run onopened,synchronize,reopened, andready_for_review; Draft PRs skip the full suite. Preserve the existing main push trigger, job name, read-only permissions, concurrency and every validation step. No manual trigger is added.pr-draft: always; closing/reopening a Draft PR does not bypass the guard, and changing token type does not remove it. No executable release behavior or permissions change.Validation
gh repo-checks repositoryandgit diff --check— passed.actionlint1.7.12 on.github/workflows/ci.ymland.github/workflows/version-packages.yml— passed.gh repo-checks pr-titleandgh repo-checks pr-body— checked for the prepared title/body before publication.76de05c305c895696b72da624f7e834bc4f3bd69: CI 41609207363 skippedcheckwith zero steps, while Draft Review 41609207466 passed all three lightweight checks. The skipped CI job demonstrates the Draft policy; it is not test execution.checkactually executingpnpm run check(format, build, lint, typecheck, tests and package checks). Ready Review 41609345250 also passed all three checks.b9c30256739472a768b0d391837efc7630167a42, combining the then-current main2b1a2f12b7d19f5d5b3295374715c177ec90cf05with the final PR head. The hosted aggregate gate used the declared toolchain; the isolated local checkout did not reuse dependencies from another working tree.d11379fb050b441141448eef53662c0b85c80eef, main-push CI 41611277160 also passed with the fullcheckjob actually executing. These are completed results, separate from the static policy matrix above.Risks
The read-only protection audit found
checkand the three Review jobs required, admin enforcement enabled, zero required approvals, and non-strict status checks. Those settings are unchanged. GitHub counts skipped jobs as successful, so confirm an executed successfulcheckon the current head and merge result; a skipped Draft result or an older comparison is insufficient evidence.GitHub may require maintainer approval for PR events created with
GITHUB_TOKEN. This change neither broadens tokens nor modifies account/security settings. It preserves the existing release Draft handoff and main-push validation. No PR is merged or closed by this change.