Repository navigation
fix: drop the premature duplicates gate - #315
Closed
PerfectPan wants to merge 1 commit into
Closed
PerfectPan wants to merge 1 commit into
PerfectPan wants to merge 1 commit into
Conversation
The script added in #311 uses the lint-config gate config whose threshold is 0 — jscpd fails on any duplication, so it can never pass before the dedup pass the issue defers the gate to. Keep duplicates:audit.
Owner
Author
|
Closing without merging: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #311 加了
pnpm duplicates脚本,但它用的 lint-config gate 配置 threshold 为 0——jscpd 对任何重复率都会 exit 1,在去重专项完成前这个 gate 永远过不了(issue 里 jscpd 条款写明 gate 延后、仅 audit)。本 PR 移除该脚本,保留duplicates:audit。去重专项落地后再按 issue 承诺装回带基线的 gate。