Skip to content

fix: drop the premature duplicates gate - #315

Closed
PerfectPan wants to merge 1 commit into
mainfrom
fix/drop-premature-duplicates-gate
Closed

PerfectPan wants to merge 1 commit into
mainfrom
fix/drop-premature-duplicates-gate

Conversation

@PerfectPan

Copy link
Copy Markdown
Owner

PR #311 加了 pnpm duplicates 脚本,但它用的 lint-config gate 配置 threshold 为 0——jscpd 对任何重复率都会 exit 1,在去重专项完成前这个 gate 永远过不了(issue 里 jscpd 条款写明 gate 延后、仅 audit)。本 PR 移除该脚本,保留 duplicates:audit。

去重专项落地后再按 issue 承诺装回带基线的 gate。

The script added in #311 uses the lint-config gate config whose threshold
is 0 — jscpd fails on any duplication, so it can never pass before the
dedup pass the issue defers the gate to. Keep duplicates:audit.
@PerfectPan

Copy link
Copy Markdown
Owner Author

Closing without merging: the duplicates script stays. We keep lint-config's zero-threshold gate (whole tree, no baseline of existing clones). main currently reports 119 clones, mostly the per-provider events/hooks/usage mirrors listed in #308, so the gate stays out of CI until they are shared or excluded in the script with a reason; pnpm duplicates:audit is the worklist. CI starts running pnpm duplicates once it reports 0.

@PerfectPan PerfectPan closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant