Skip to content

ci: align ready pull request checks with templates - #154

Merged
PerfectPan merged 1 commit into
mainfrom
ci/ready-pr-checks
Nov 3, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
ci/ready-pr-checks

Conversation

@PerfectPan

@PerfectPan PerfectPan commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

Adopt the Ready/Draft CI policy prepared first in project-template #9. Full CI runs when a non-Draft pull request is opened, receives new commits, is reopened, or becomes Ready for review. Draft events skip the full test matrix; the existing main push trigger remains active.

  • Preserve the Ubuntu/macOS matrix, test steps, check names and read-only CI permissions.
  • Keep the separate lightweight Review workflow unchanged, including Draft and metadata feedback. It checks repository conventions, the title and the description without installing project dependencies or running the test suite.
  • Update contribution and release instructions to distinguish a skipped job from successful test execution and describe the current GITHUB_TOKEN approval/Ready handoff. The Publish workflow changes only comments; its existing release-PR Draft behavior, versioning, publishing and credentials are unchanged.
  • Keep the independent Dependabot-retirement PR separate. Renovate, Dependabot, dependencies, package output and security settings do not change.

Validation

  • gh repo-checks repository, git diff --check, and the public-content scan passed.
  • actionlint 1.7.12 passed for CI, Review and Publish.
  • A 44-case static check of the actual YAML passed for Ready/Draft events, human/Bot authors and actors, the retained main push, excluded events and Review's Bot-description exemption. It also verified that Review is byte-identical, Publish is unchanged when parsed, and CI steps, the OS matrix, dependency files and updater configuration are unchanged. This is configuration validation, not proof of hosted event delivery.
  • The same locked formatter passed ./node_modules/.bin/vp fmt --check on 240 files. Local pnpm format:check rejected reused dependencies in the isolated worktree with ERR_PNPM_VERIFY_DEPS_BEFORE_RUN; both hosted matrix jobs subsequently passed fresh installs through the actual pnpm scripts.
  • PR title and body checks passed locally. This maintenance change does not need a changeset.
  • Real Draft observation on final head f389a11e52877c05856f6de009f4eca9545c440e: CI 41609633875 skipped the full test job, while Draft Review 41609633978 passed all three lightweight checks. The skipped CI result is not counted as test execution.
  • Marking that unchanged head Ready triggered full CI 41609781183, which passed both actual jobs, test (ubuntu-latest) and test (macos-latest). Each performed the frozen pnpm install, format, tests, typecheck, docs sync, lint, build and pack checks. Ubuntu reported 998 tests passed / 6 skipped; macOS reported 1003 passed / 1 skipped. The prepack test reruns also passed.
  • Both Ready-run checkout logs confirm tested merge dfcbd08283f602fce571a8b2fbed43d1a44001eb, combining the then-current main 867ad7e635c44c88a86e648d241a83e267626109 with the final PR head. Ready Review 41609781161 also passed all three checks.
  • After squash merge 7d6ec32056569952fc732ae6250131bdb196f13f, main-push CI 41611310657 passed both complete Ubuntu/macOS jobs. These are completed results, separate from the static policy matrix above.

Risks

The existing Default ruleset blocks deletion and force pushes, but it does not currently require pull requests or status checks. No protection setting is changed here. Maintainers must verify successful, executed checks for the exact current head before merging; GitHub's skipped-success status alone is insufficient.

Release PRs created or updated with GITHUB_TOKEN can wait for maintainer approval. This change adds no token permissions or release automation and retains the existing release behavior. A real Renovate update PR remains a separate end-to-end observation from this CI-policy PR.

@vercel

vercel Bot commented Nov 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
agent-presence Ready Ready Preview Nov 3, 2026 9:16am UTC

@PerfectPan
PerfectPan marked this pull request as ready for review November 3, 2026 09:17
@PerfectPan
PerfectPan merged commit 7d6ec32 into main Nov 3, 2026
11 checks passed
@PerfectPan
PerfectPan deleted the ci/ready-pr-checks branch November 3, 2026 09:28

This branch was successfully deployed

1 active deployment
Preview — f389a11e Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant