Repository navigation
ci: align ready pull request checks with templates - #154
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopt the Ready/Draft CI policy prepared first in project-template #9. Full CI runs when a non-Draft pull request is opened, receives new commits, is reopened, or becomes Ready for review. Draft events skip the full test matrix; the existing
mainpush trigger remains active.GITHUB_TOKENapproval/Ready handoff. The Publish workflow changes only comments; its existing release-PR Draft behavior, versioning, publishing and credentials are unchanged.Validation
gh repo-checks repository,git diff --check, and the public-content scan passed.actionlint1.7.12 passed for CI, Review and Publish../node_modules/.bin/vp fmt --checkon 240 files. Localpnpm format:checkrejected reused dependencies in the isolated worktree withERR_PNPM_VERIFY_DEPS_BEFORE_RUN; both hosted matrix jobs subsequently passed fresh installs through the actual pnpm scripts.f389a11e52877c05856f6de009f4eca9545c440e: CI 41609633875 skipped the full test job, while Draft Review 41609633978 passed all three lightweight checks. The skipped CI result is not counted as test execution.test (ubuntu-latest)andtest (macos-latest). Each performed the frozen pnpm install, format, tests, typecheck, docs sync, lint, build and pack checks. Ubuntu reported 998 tests passed / 6 skipped; macOS reported 1003 passed / 1 skipped. The prepack test reruns also passed.dfcbd08283f602fce571a8b2fbed43d1a44001eb, combining the then-current main867ad7e635c44c88a86e648d241a83e267626109with the final PR head. Ready Review 41609781161 also passed all three checks.7d6ec32056569952fc732ae6250131bdb196f13f, main-push CI 41611310657 passed both complete Ubuntu/macOS jobs. These are completed results, separate from the static policy matrix above.Risks
The existing
Defaultruleset blocks deletion and force pushes, but it does not currently require pull requests or status checks. No protection setting is changed here. Maintainers must verify successful, executed checks for the exact current head before merging; GitHub's skipped-success status alone is insufficient.Release PRs created or updated with
GITHUB_TOKENcan wait for maintainer approval. This change adds no token permissions or release automation and retains the existing release behavior. A real Renovate update PR remains a separate end-to-end observation from this CI-policy PR.