Repository navigation
refactor: share the publish flow, installer plumbing and schema parse helpers - #167
Merged
Merged
Conversation
… helpers Everything #165 staged behind business excludes is now shared code, so the duplicates gate runs without them: - flush/reset/update share one publish flow (publish-run.ts: setup, queue settle, takeover+print, and the rendered sync with per-command deltas) - install/uninstall script mirrors share scripts/lib/cli.ts (exit handler, dsh patch report) and scripts/lib/power-watch.ts (labels, launchctl, uid, env-overridable paths) - config-schema reports every dropped value through one parseOrReport helper - both coding-agent hooks resolve the project through pickProject knip loses ignoreBinaries: ['mkfifo']: the recovery test's FIFO rendezvous is replaced by an optional requestDelayMs on the watchdog thread (sync Atomics sleep, the same injection style as the clock/delay seams), so the invalidation test keeps its determinism without shelling out.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #166 — everything #165 staged behind business excludes is now shared code, so the
duplicatesgate runs without any of them (only the standing**/*.test.tsconvention remains).Summary
**/cli/commands/*.tsremoved:flush/reset/updateshare one publish flow (src/cli/commands/publish-run.ts:setupPublishCommand,settleQueue,runPublishCommand,runRenderedPublish); each command keeps only its own delta.**/install-*.ts,**/uninstall-*.tsremoved: the dsh pair sharesscripts/lib/cli.ts(runScriptMain,reportDshPatchOutcome); the power-watch pair sharesscripts/lib/power-watch.ts(labels,launchctl,currentUid,powerWatchPaths).**/config-schema.tsremoved:configField,parseOrDropandentriesThatParsereport every drop through oneparseOrReporthelper.**/hooks/*.tsremoved: the project picker both hook contexts need ispickProjectinhooks/context.ts.ignoreBinaries: ['mkfifo']removed:test/queue-worker-recovery.test.tsno longer shells out to mkfifo. The FIFO rendezvous is replaced by an optionalrequestDelayMson the watchdog thread's workerData (a syncAtomics.waitsleep, the same injection style as the repo's clock/delay seams); the child writes the request before the first stale tick and flips the heartbeat inside the simulated I/O window, so both invalidation cases keep their determinism without an external binary.Validation
pnpm lint,pnpm typecheck,pnpm format:checkclean.pnpm test1046 passed;test/queue-worker-recovery.test.tsrun 4× for determinism.pnpm knipandpnpm knip:productionclean without the ignore.pnpm duplicates0 clones with every business exclude gone.duplicates:auditcandidates 62 → 50; the remainder is the audit-only worklist the issue already tracks.