Skip to content

ci(checks): run Knip in pull request CI - #171

Merged
PerfectPan merged 1 commit into
mainfrom
ci/knip-gate
Nov 18, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
ci/knip-gate

Conversation

@PerfectPan

Copy link
Copy Markdown
Owner

Summary

  • Run the existing pnpm knip and pnpm knip:production scripts as separate steps in the Ubuntu and macOS CI jobs after docs type generation and linting. Both scripts passed on the base commit (fbff6f1).
  • The shared @perfectpan/lint-config/knip rules fail CI on unused files, exports, dependencies, and configuration or tag hints. The production check uses production entry points. Both checks are listed in the contributor and agent instructions and the PR and MR checklists.

Validation

  • pnpm install --frozen-lockfile and pnpm peers check --lockfile-only passed. The lockfile stayed unchanged.
  • pnpm -C site run docs:sync, pnpm format:check, pnpm lint, pnpm run typecheck, and pnpm duplicates passed. The duplicate check found zero clones.
  • With an unreferenced function in site/src/knip-probe.ts, pnpm knip and pnpm knip:production each reported Unused files (1) and the probe path, and exited 1. After removing it, both exited 0.
  • pnpm test passed (1,046 passed, one skipped). pnpm run build, node dist/src/cli.js --help, pnpm pack --dry-run, and pnpm -C site run docs:build passed.
  • pnpm changeset status exited 1 because the branch has no changeset. It exited 0 in a clean checkout of the base commit. CI's gh repo-checks release-plan passed with zero pending records. CI and documentation changes qualify for the maintenance exemption in CONTRIBUTING.md.
  • gh repo-checks repository, gh repo-checks pr-title, gh repo-checks pr-body, and git diff --cached --check passed.

Co-Authored-By: Codex <noreply@openai.com>
@vercel

vercel Bot commented Nov 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
agent-presence Ready Ready Preview Nov 18, 2026 1:54pm UTC

@PerfectPan
PerfectPan merged commit b6153bb into main Nov 18, 2026
8 checks passed
@PerfectPan
PerfectPan deleted the ci/knip-gate branch November 18, 2026 14:23

This branch was successfully deployed

1 active deployment
Preview — 7b3d4642 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant