Repository navigation
ci(checks): run Knip in pull request CI - #171
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm knipandpnpm knip:productionscripts as separate steps in the Ubuntu and macOS CI jobs after docs type generation and linting. Both scripts passed on the base commit (fbff6f1).@perfectpan/lint-config/kniprules fail CI on unused files, exports, dependencies, and configuration or tag hints. The production check uses production entry points. Both checks are listed in the contributor and agent instructions and the PR and MR checklists.Validation
pnpm install --frozen-lockfileandpnpm peers check --lockfile-onlypassed. The lockfile stayed unchanged.pnpm -C site run docs:sync,pnpm format:check,pnpm lint,pnpm run typecheck, andpnpm duplicatespassed. The duplicate check found zero clones.site/src/knip-probe.ts,pnpm knipandpnpm knip:productioneach reportedUnused files (1)and the probe path, and exited 1. After removing it, both exited 0.pnpm testpassed (1,046 passed, one skipped).pnpm run build,node dist/src/cli.js --help,pnpm pack --dry-run, andpnpm -C site run docs:buildpassed.pnpm changeset statusexited 1 because the branch has no changeset. It exited 0 in a clean checkout of the base commit. CI'sgh repo-checks release-planpassed with zero pending records. CI and documentation changes qualify for the maintenance exemption in CONTRIBUTING.md.gh repo-checks repository,gh repo-checks pr-title,gh repo-checks pr-body, andgit diff --cached --checkpassed.