Repository navigation
ci: run full checks only for ready pull requests - #178
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Synchronize the shared full-CI policy prepared in project-template #9 and its pnpm implementation #3. Ready PRs run on opened, synchronize, reopened and ready_for_review; Draft PR events skip the full test job. Preserve main push, the existing pnpm steps, the test check name and read-only CI permissions; no manual trigger is added.
Keep lightweight Review checks active for Draft and metadata feedback. Keep publishing behavior and the existing release-PR creation policy unchanged; only correct outdated GITHUB_TOKEN and Draft/Ready instructions in CONTRIBUTING, the publish runbook and workflow comments. No application, package, dependency, lockfile, Renovate or Dependabot changes are included. The separate Dependabot retirement PR #177 is untouched; no changeset is needed for this maintenance change.
Validation
d13883119a34355ea8ac90d4495b71acc1328ef4, Draft CI correctly skippedtest, while Draft Review actually passed all three jobs. The skipped job is not a test pass.59c402442cb1c9477e616fb57b2c90e39d59efb3, combining maine520872460dfd63c52edb430d4a0bb7a064dfef0with this head. The final results-only description was checked locally; its edited-event Review is tracked separately. The PR remains Ready; no merge or publishing was performed by this preparation task.Risks
GitHub can report a skipped job as successful even when required, so verify that the full test job actually executed for the current Ready head and merge result. Read-only inspection found that the Default ruleset only prevents deletion and force pushes; required PR/status checks are not configured. No repository settings are changed. GITHUB_TOKEN-created PR events may wait for a maintainer's workflow approval. This change does not run or alter publishing.