Skip to content

ci: run full checks only for ready pull requests - #178

Merged
PerfectPan merged 1 commit into
mainfrom
ci/ready-pr-policy
Nov 3, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
ci/ready-pr-policy

Conversation

@PerfectPan

@PerfectPan PerfectPan commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

Synchronize the shared full-CI policy prepared in project-template #9 and its pnpm implementation #3. Ready PRs run on opened, synchronize, reopened and ready_for_review; Draft PR events skip the full test job. Preserve main push, the existing pnpm steps, the test check name and read-only CI permissions; no manual trigger is added.

Keep lightweight Review checks active for Draft and metadata feedback. Keep publishing behavior and the existing release-PR creation policy unchanged; only correct outdated GITHUB_TOKEN and Draft/Ready instructions in CONTRIBUTING, the publish runbook and workflow comments. No application, package, dependency, lockfile, Renovate or Dependabot changes are included. The separate Dependabot retirement PR #177 is untouched; no changeset is needed for this maintenance change.

Validation

  • pnpm 12.8.1 install --frozen-lockfile passed with isolated caches; package manifests and lockfile are unchanged.
  • pnpm format:check passed across 512 files. The final-head hosted CI below also executed the existing test/build/typecheck/lint gates.
  • actionlint 1.7.12 on CI and Publish, gh repo-checks repository and git diff --check passed.
  • A 32-case static matrix parses the actual workflow YAML and evaluates Ready/Draft, user/Bot, PR/main-push and excluded-event routing, plus Review body exemptions. It is policy validation, not proof of GitHub event delivery.
  • Structural comparison confirms only the CI activity list and job guard change executable behavior. Publish YAML semantics, Review, dependency-update configs, manifests and lockfile are unchanged. Independent local review passed.
  • On final head d13883119a34355ea8ac90d4495b71acc1328ef4, Draft CI correctly skipped test, while Draft Review actually passed all three jobs. The skipped job is not a test pass.
  • Marking this same PR Ready started full CI, which executed and passed frozen installation, formatting, peer checks, all 844 tests (15 repository tests and 829 workspace tests), build, typecheck and lint. Ready Review also passed.
  • Checkout logs confirm merge 59c402442cb1c9477e616fb57b2c90e39d59efb3, combining main e520872460dfd63c52edb430d4a0bb7a064dfef0 with this head. The final results-only description was checked locally; its edited-event Review is tracked separately. The PR remains Ready; no merge or publishing was performed by this preparation task.

Risks

GitHub can report a skipped job as successful even when required, so verify that the full test job actually executed for the current Ready head and merge result. Read-only inspection found that the Default ruleset only prevents deletion and force pushes; required PR/status checks are not configured. No repository settings are changed. GITHUB_TOKEN-created PR events may wait for a maintainer's workflow approval. This change does not run or alter publishing.

@PerfectPan
PerfectPan marked this pull request as ready for review November 3, 2026 09:17
@PerfectPan
PerfectPan merged commit f4be381 into main Nov 3, 2026
11 checks passed
@PerfectPan
PerfectPan deleted the ci/ready-pr-policy branch November 3, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant