Skip to content

build(deps): adopt lint-config v0.8.0 with knip and jscpd audit - #191

Merged
PerfectPan merged 2 commits into
mainfrom
chore/upgrade-lint-config-v0.8.0
Nov 15, 2026
Merged

PerfectPan merged 2 commits into
mainfrom
chore/upgrade-lint-config-v0.8.0

Conversation

@PerfectPan

@PerfectPan PerfectPan commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Bump @perfectpan/lint-config v0.7.1 → v0.8.0. Per the release notes this changes nothing for the existing lint, format and type-check results.
  • Adopt Knip with the shared policy from @perfectpan/lint-config/knip (configuration and tag hints fail the run). Staged adoption: exclude: ['exports', 'types'] until a dedicated unused-export cleanup pass; everything else (unused files/dependencies, unlisted binaries, hints) is enforced and currently clean.
  • Clean up what the first Knip run surfaced:
    • remove root @rivus/agent-finder-cli, @rivus/agent-task-loop, @types/react, @types/react-dom (nothing imports them; both apps declare their own React types),
    • remove the unused tsx devDependency in @rivus/agent-room,
    • delete the dead packages/agent-task-loop/src/orchestration/{file-store,node-paths}.ts.
  • Adopt jscpd via the report-only audit profile (duplicates:audit, output in git-ignored tmp/). The zero-threshold gate is deferred on purpose: 45 pre-existing clones across ~20 files (e.g. 12 fragments in feishu-task-provider.ts) need a refactor pass first — the audit report is the worklist.
  • lark-cli and the shadcn/ui component set are annotated in knip.ts so they are not false positives.

Validation

  • pnpm lint — 0 warnings, 0 errors (after react-router typegen; the fresh-checkout TS2307s are pre-existing).
  • pnpm typecheck — pass.
  • pnpm knip — pass.
  • pnpm duplicates:audit — report-only, 269 candidates in tmp/duplicates-audit/.

Tracking issue: #192 (exclusion worklist, staged rules and removal conditions live there).

- Bump `@perfectpan/lint-config` from `v0.7.1` to `v0.8.0` (no change to
  existing lint/format/type-check results).
- Add `knip` with the shared Knip policy from `@perfectpan/lint-config/knip`;
  configuration and tag hints now fail the run. Unused exports/types are staged
  for a dedicated cleanup pass (`exclude: ['exports', 'types']`).
- Clean up what Knip surfaced: remove the root `@rivus/agent-finder-cli`,
  `@rivus/agent-task-loop`, `@types/react` and `@types/react-dom`
  dependencies nothing imports, the unused `tsx` devDependency in
  `@rivus/agent-room`, and the dead `src/orchestration/file-store.ts` and
  `src/orchestration/node-paths.ts`.
- Add the `duplicates:audit` jscpd audit profile (report-only, output in the
  git-ignored `tmp/`). The zero-threshold gate is deferred: 45 pre-existing
  clones are spread across ~20 files, so the report lists them for a follow-up
  refactor before the gate can pass.
vp fmt --check flags the missing trailing commas; the repo style is
trailingComma: 'all' (see the root vite config).
@PerfectPan
PerfectPan merged commit 47d5dda into main Nov 15, 2026
5 checks passed
@PerfectPan
PerfectPan deleted the chore/upgrade-lint-config-v0.8.0 branch November 15, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant