Repository navigation
build(deps): adopt lint-config v0.8.0 with knip and jscpd audit - #191
Merged
Merged
Conversation
- Bump `@perfectpan/lint-config` from `v0.7.1` to `v0.8.0` (no change to existing lint/format/type-check results). - Add `knip` with the shared Knip policy from `@perfectpan/lint-config/knip`; configuration and tag hints now fail the run. Unused exports/types are staged for a dedicated cleanup pass (`exclude: ['exports', 'types']`). - Clean up what Knip surfaced: remove the root `@rivus/agent-finder-cli`, `@rivus/agent-task-loop`, `@types/react` and `@types/react-dom` dependencies nothing imports, the unused `tsx` devDependency in `@rivus/agent-room`, and the dead `src/orchestration/file-store.ts` and `src/orchestration/node-paths.ts`. - Add the `duplicates:audit` jscpd audit profile (report-only, output in the git-ignored `tmp/`). The zero-threshold gate is deferred: 45 pre-existing clones are spread across ~20 files, so the report lists them for a follow-up refactor before the gate can pass.
PerfectPan
force-pushed
the
chore/upgrade-lint-config-v0.8.0
branch
from
November 15, 2026 12:16
f6a1716 to
4ac723d
Compare
vp fmt --check flags the missing trailing commas; the repo style is trailingComma: 'all' (see the root vite config).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@perfectpan/lint-configv0.7.1→v0.8.0. Per the release notes this changes nothing for the existing lint, format and type-check results.@perfectpan/lint-config/knip(configuration and tag hints fail the run). Staged adoption:exclude: ['exports', 'types']until a dedicated unused-export cleanup pass; everything else (unused files/dependencies, unlisted binaries, hints) is enforced and currently clean.@rivus/agent-finder-cli,@rivus/agent-task-loop,@types/react,@types/react-dom(nothing imports them; both apps declare their own React types),tsxdevDependency in@rivus/agent-room,packages/agent-task-loop/src/orchestration/{file-store,node-paths}.ts.duplicates:audit, output in git-ignoredtmp/). The zero-threshold gate is deferred on purpose: 45 pre-existing clones across ~20 files (e.g. 12 fragments infeishu-task-provider.ts) need a refactor pass first — the audit report is the worklist.lark-cliand the shadcn/ui component set are annotated inknip.tsso they are not false positives.Validation
pnpm lint— 0 warnings, 0 errors (afterreact-router typegen; the fresh-checkout TS2307s are pre-existing).pnpm typecheck— pass.pnpm knip— pass.pnpm duplicates:audit— report-only, 269 candidates intmp/duplicates-audit/.Tracking issue: #192 (exclusion worklist, staged rules and removal conditions live there).