Skip to content

fix: drop the premature duplicates gate - #196

Closed
PerfectPan wants to merge 1 commit into
mainfrom
fix/drop-premature-duplicates-gate
Closed

PerfectPan wants to merge 1 commit into
mainfrom
fix/drop-premature-duplicates-gate

Conversation

@PerfectPan

Copy link
Copy Markdown
Owner

lint-config v0.8.0 接入时提前装了 pnpm duplicates 脚本,但 issue 的 jscpd 条款写明 gate deferred(去重专项后再装回);lint-config gate 配置 threshold 为 0,jscpd 对任何存量重复都 exit 1,这个 gate 在去重前永远过不了。本 PR 移除该脚本,保留 duplicates:audit(行为不变)。

Issue defers the zero-threshold gate until the tracked per-provider
duplication is deduped; jscpd's lint-config gate config uses threshold 0,
so the script fails on any remaining clone. Keep duplicates:audit.
@PerfectPan

PerfectPan commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner Author

Closing without merging: the duplicates script stays. We keep lint-config's zero-threshold gate for the whole tree. #195 brought the 45 clones #192 listed down to one, #198 shared that last one, and CI now runs pnpm duplicates. One gap remains: the script's --format 'typescript,javascript' does not scan .tsx (8 clones once tsx is added), tracked in #199.

@PerfectPan PerfectPan closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant