Skip to content

ci(checks): run Knip on pull requests - #200

Merged
PerfectPan merged 1 commit into
mainfrom
ci/knip-gate
Nov 18, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
ci/knip-gate

Conversation

@PerfectPan

Copy link
Copy Markdown
Owner

Summary

Run the existing pnpm knip script in the PR test job after build, type generation, and lint. Knip checks for unused files, exports, and dependencies. Its shared lint-config policy also treats configuration and tag hints as errors. Update the local verification instructions and the GitHub and GitLab review checklists.

Validation

  • On main at fc87403, pnpm knip passed on a fresh install and after pnpm build and pnpm typecheck. The separate diagnostic pnpm exec knip --production exited 1 in both cases with 7 unused files, 1 unused dependency, 35 unused exports, and 7 unused exported types. CI runs the existing regular-mode script.
  • Added an unreferenced packages/agent-task-loop/src/knip-probe.ts with one exported function. pnpm knip exited 1 and reported that path. Removing the probe returned the same command to exit 0.
  • pnpm install --frozen-lockfile, pnpm format:check, pnpm duplicates (0 clones), pnpm build, pnpm typecheck, and pnpm lint passed.
  • pnpm test failed twice on the branch in kills descendant processes when the cancel signal aborts. The cancelled process returned 0 where the test expected a nonzero exit. The full suite passed in a fresh checkout of the same base commit. From packages/agent-task-loop, pnpm exec vp test run src/orchestration/execa-runner.test.ts passed three consecutive times, each with 1 test passed and exit 0.
  • gh repo-checks repository, gh repo-checks release-plan (0 pending records), gh repo-checks pr-title "ci(checks): run Knip on pull requests", and gh repo-checks pr-body <body-file> passed.
  • pnpm changeset status passed before and after commit. No published package changed. The changeset policy permits skipping a changeset for repository maintenance. Package dry-runs apply to changed published packages.

Co-Authored-By: Codex <noreply@openai.com>
@PerfectPan
PerfectPan merged commit b3b058a into main Nov 18, 2026
5 checks passed
@PerfectPan
PerfectPan deleted the ci/knip-gate branch November 18, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant