Repository navigation
ci(checks): run Knip on pull requests - #200
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the existing
pnpm knipscript in the PR test job after build, type generation, and lint. Knip checks for unused files, exports, and dependencies. Its shared lint-config policy also treats configuration and tag hints as errors. Update the local verification instructions and the GitHub and GitLab review checklists.Validation
mainatfc87403,pnpm knippassed on a fresh install and afterpnpm buildandpnpm typecheck. The separate diagnosticpnpm exec knip --productionexited 1 in both cases with 7 unused files, 1 unused dependency, 35 unused exports, and 7 unused exported types. CI runs the existing regular-mode script.packages/agent-task-loop/src/knip-probe.tswith one exported function.pnpm knipexited 1 and reported that path. Removing the probe returned the same command to exit 0.pnpm install --frozen-lockfile,pnpm format:check,pnpm duplicates(0 clones),pnpm build,pnpm typecheck, andpnpm lintpassed.pnpm testfailed twice on the branch inkills descendant processes when the cancel signal aborts. The cancelled process returned 0 where the test expected a nonzero exit. The full suite passed in a fresh checkout of the same base commit. Frompackages/agent-task-loop,pnpm exec vp test run src/orchestration/execa-runner.test.tspassed three consecutive times, each with 1 test passed and exit 0.gh repo-checks repository,gh repo-checks release-plan(0 pending records),gh repo-checks pr-title "ci(checks): run Knip on pull requests", andgh repo-checks pr-body <body-file>passed.pnpm changeset statuspassed before and after commit. No published package changed. The changeset policy permits skipping a changeset for repository maintenance. Package dry-runs apply to changed published packages.