Repository navigation
refactor(agent-task-loop): remove the unused execa process runner - #203
Merged
Merged
Conversation
execaProcessRunner lost its last caller when the task lease moved to agent-kit-collab; only its test imported it, and no package export reaches it. Its cancel test failed under load. Delete both, and name the ProcessRunner port in the architecture doc instead. Closes #201 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #201.
src/orchestration/execa-runner.test.tsfailed under machine load, but the runner it tests has had no caller since #152:createOrchestrationstopped defaulting toexecaProcessRunnerwhen the task lease moved to@rivus/agent-kit-collab. Nothing imports it except its test, and no package export reaches it (./task-delivery,./task-management,./rivus-plugin; the build entries invite.config.tsdo not either).MemoryOrchestratedTaskRuntimetakes itsProcessRunnerfrom the caller, and no PerfectPan repository other than this one's tests constructs it. #179 gave the runnerkillDescendantswithout knowing that it was no longer used.src/orchestration/execa-runner.tsand its test instead of fixing a race in code nothing runs. The agent path,runAgentCommandinsrc/adapters/base.ts, keeps its ownkillDescendantsand tests.docs/architecture/task-sources.mdno longer says the process runner lives insrc/orchestration/; it names theProcessRunnerport, which the caller implements.killDescendantsindist/comes fromadapters/base.ts), so published behavior does not change (CONTRIBUTING.md:102, as in refactor: share the provider/service shapes and drop the knip export staging #195).Validation
git log -S execaProcessRunner: the last production caller was removed in a7be2e7 (feat(kit): replace task leases with @rivus/agent-kit-collab #152).gh search code --owner PerfectPan execaProcessRunnerreturns only the two deleted files.pnpm format:check,pnpm duplicates,pnpm knip,gh repo-checks repository,pnpm build,pnpm typecheck,pnpm lint: exit 0.pnpm test: exit 0 (agent-task-loop 544, one fewer than before; agent-room 70; agent-finder-cli 23; room-web 195).pnpm exec knip --production: unused files drop from 7 to 6; the rest is [Task]: run knip --production in CI #202.