Skip to content

refactor(agent-task-loop): remove the unused execa process runner - #203

Merged
PerfectPan merged 1 commit into
mainfrom
refactor/remove-execa-runner
Nov 18, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
refactor/remove-execa-runner

Conversation

@PerfectPan

Copy link
Copy Markdown
Owner

Summary

Closes #201. src/orchestration/execa-runner.test.ts failed under machine load, but the runner it tests has had no caller since #152: createOrchestration stopped defaulting to execaProcessRunner when the task lease moved to @rivus/agent-kit-collab. Nothing imports it except its test, and no package export reaches it (./task-delivery, ./task-management, ./rivus-plugin; the build entries in vite.config.ts do not either). MemoryOrchestratedTaskRuntime takes its ProcessRunner from the caller, and no PerfectPan repository other than this one's tests constructs it. #179 gave the runner killDescendants without knowing that it was no longer used.

  • Delete src/orchestration/execa-runner.ts and its test instead of fixing a race in code nothing runs. The agent path, runAgentCommand in src/adapters/base.ts, keeps its own killDescendants and tests.
  • docs/architecture/task-sources.md no longer says the process runner lives in src/orchestration/; it names the ProcessRunner port, which the caller implements.
  • No changeset: the file never reached a published build (the only killDescendants in dist/ comes from adapters/base.ts), so published behavior does not change (CONTRIBUTING.md:102, as in refactor: share the provider/service shapes and drop the knip export staging #195).

Validation

  • git log -S execaProcessRunner: the last production caller was removed in a7be2e7 (feat(kit): replace task leases with @rivus/agent-kit-collab #152). gh search code --owner PerfectPan execaProcessRunner returns only the two deleted files.
  • pnpm format:check, pnpm duplicates, pnpm knip, gh repo-checks repository, pnpm build, pnpm typecheck, pnpm lint: exit 0.
  • pnpm test: exit 0 (agent-task-loop 544, one fewer than before; agent-room 70; agent-finder-cli 23; room-web 195).
  • pnpm exec knip --production: unused files drop from 7 to 6; the rest is [Task]: run knip --production in CI #202.

execaProcessRunner lost its last caller when the task lease moved to
agent-kit-collab; only its test imported it, and no package export
reaches it. Its cancel test failed under load. Delete both, and name
the ProcessRunner port in the architecture doc instead.

Closes #201

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@PerfectPan
PerfectPan merged commit 5082bd8 into main Nov 18, 2026
5 checks passed
@PerfectPan
PerfectPan deleted the refactor/remove-execa-runner branch November 18, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: execa-runner cancel test reports exit code 0 under load

1 participant