Repository navigation
ci(checks): run Knip in pull request CI - #182
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://ci-knip-gate.preview.perfectpan.org (commit 84c7179)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm knipandpnpm knip:productionscripts in separate steps after linting in the PR build job. Both passed onmasteratfdef9c8.@perfectpan/lint-config/kniprules fail the job on unused files, exports, dependencies, and configuration or tag hints. The production check evaluates production code separately. Add both commands to the existing local verification lists and PR checklist.Validation
pnpm install --frozen-lockfilepassed. The tracked route tree was present in the fresh checkout, and the lockfile stayed unchanged.apps/web/src/knip-probe.ts,pnpm knipandpnpm knip:productioneach reportedUnused files (1)and the probe path and exited 1. After removing the file, both exited 0.pnpm typecheck,pnpm lint,pnpm duplicates, andpnpm testpassed (zero clones and 54 passing unit tests).pnpm --filter @blog/web buildpassed.pnpm --filter @blog/web exec wrangler deploy -c dist/server/wrangler.json --dry-runreported 1,200.53 KiB gzip, below the 3 MiB cap.E2E_BASE_URL=https://ci-knip-gate.preview.perfectpan.org pnpm exec playwright test tests/e2e/preview-smoke.spec.tspassed all three tests. They covered page hydration and navigation, KaTeX rendering, and search results.$ knipand$ knip --production. GitHub Actions build log