Skip to content

ci(checks): run Knip in pull request CI - #182

Merged
PerfectPan merged 2 commits into
masterfrom
ci/knip-gate
Nov 18, 2026
Merged

PerfectPan merged 2 commits into
masterfrom
ci/knip-gate

Conversation

@PerfectPan

@PerfectPan PerfectPan commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Run the existing pnpm knip and pnpm knip:production scripts in separate steps after linting in the PR build job. Both passed on master at fdef9c8.
  • The shared @perfectpan/lint-config/knip rules fail the job on unused files, exports, dependencies, and configuration or tag hints. The production check evaluates production code separately. Add both commands to the existing local verification lists and PR checklist.

Validation

  • pnpm install --frozen-lockfile passed. The tracked route tree was present in the fresh checkout, and the lockfile stayed unchanged.
  • With an unreferenced function in apps/web/src/knip-probe.ts, pnpm knip and pnpm knip:production each reported Unused files (1) and the probe path and exited 1. After removing the file, both exited 0.
  • pnpm typecheck, pnpm lint, pnpm duplicates, and pnpm test passed (zero clones and 54 passing unit tests).
  • pnpm --filter @blog/web build passed. pnpm --filter @blog/web exec wrangler deploy -c dist/server/wrangler.json --dry-run reported 1,200.53 KiB gzip, below the 3 MiB cap.
  • The read-only preview smoke command E2E_BASE_URL=https://ci-knip-gate.preview.perfectpan.org pnpm exec playwright test tests/e2e/preview-smoke.spec.ts passed all three tests. They covered page hydration and navigation, KaTeX rendering, and search results.
  • The PR build passed and its log records both $ knip and $ knip --production. GitHub Actions build log

Co-Authored-By: Codex <noreply@openai.com>
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://ci-knip-gate.preview.perfectpan.org (commit 84c7179)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://027e5aaa.preview.perfectpan.org 84c7179 2026-11-18T14:23:39.350Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://c1be9d52.preview.perfectpan.org b497b63 2026-11-18T14:14:17.044Z Visit the dashboard ↗

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@PerfectPan
PerfectPan merged commit 343bc8a into master Nov 18, 2026
5 checks passed
@PerfectPan
PerfectPan deleted the ci/knip-gate branch November 18, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant