You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Task]: Run the smoke suite in CI the way the Publish check does #146
CI builds Web on its own before the smoke step (.github/workflows/ci.yml, in test and in platforms). The Publish workflow's check runs only pnpm -C apps/e2e run test:smoke, which builds through pnpm --filter '@rivus/estela...' run build. When #134 dropped the @rivus/estela-web devDependency of @rivus/estela, that filter stopped building the web app. Every CI run stayed green, and the 0.4.0 Publish check failed with ENOENT ... apps/web/dist (run 44054543793). #145 restores the dependency, and a Knip annotation keeps it. No CI job runs the smoke suite the way the Publish check does, from a tree without a web build.
Proposed Solution
Make at least one CI job run the smoke suite from a clean tree, with no explicit Web build before it. One option is to drop the explicit Web build from the platforms job's Node.js 24 rows, which run only the smoke suite. Alternatively, run the Publish check command as a CI step.
Acceptance Criteria
A CI job fails when the @rivus/estela... build filter no longer builds the web app.
Not planned: the Publish check already fails before anything is published, as it did for 0.4.0, and the recovery is a fix PR without records (#145). The Knip annotation in knip.ts keeps the dependency from being dropped again.
Activity
PerfectPan commentedon Nov 17, 2026
Not planned: the Publish check already fails before anything is published, as it did for 0.4.0, and the recovery is a fix PR without records (#145). The Knip annotation in knip.ts keeps the dependency from being dropped again.