Repository navigation
chore(renovate): leave rolldown to the vite-plus upgrade - #147
Merged
Merged
Conversation
1 task
apps/web pins rolldown to the vite-plus core's bundledVersions.rolldown, and the CLI build fails while the pin differs. Renovate's minor/patch group still proposed rolldown on its own (1.3.1), which could only be reverted by hand. Disable rolldown updates; the maintainer moves the pin in the vite-plus toolchain PR, as CONTRIBUTING already requires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PerfectPan
force-pushed
the
chore/renovate-rolldown
branch
from
November 17, 2026 12:10
7ff5eff to
12e28ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/webpinsrolldownto the vite-plus core'sbundledVersions.rolldown, and the CLI build fails while that pin differs (Pull Request Gates). Renovate's "npm minor and patch" group still proposedrolldownon its own: #143 bumped it to 1.3.1, and the only fix was a manual revert to 1.2.14, which left that PR with no diff.This adds a
packageRulesentry that disables Renovate updates forrolldown, with the reason in itsdescription, and listsrolldownwith the other disabled updates under Bot Pull Requests inCONTRIBUTING.md. The pin keeps moving with a vite-plus upgrade, by the maintainer in the vite-plus toolchain PR (as in #78).No shipped file changes, so no changeset.
Validation
npx --package renovate@latest -- renovate-config-validator --strict renovate.json:Config validated successfully against 1 file(s).repo-checks repository,check-doc-translations,check-conventions,check-layers, and the format check all ok.Risks
enabled: falsealso stops Renovate's OSV security PRs forrolldown(the security rule forces onlyrangeStrategy, so it does not re-enable a dependency disabled by a package rule). A rolldown advisory is then caught only by the release audit (--audit-level=high), and the fix arrives through a vite-plus upgrade;CONTRIBUTING.mdnow says so. A standalone rolldown security PR could not pass the CLI build anyway.