Skip to content

chore(renovate): leave rolldown to the vite-plus upgrade - #147

Merged
PerfectPan merged 1 commit into
mainfrom
chore/renovate-rolldown
Nov 17, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
chore/renovate-rolldown

Conversation

@PerfectPan

Copy link
Copy Markdown
Owner

Summary

apps/web pins rolldown to the vite-plus core's bundledVersions.rolldown, and the CLI build fails while that pin differs (Pull Request Gates). Renovate's "npm minor and patch" group still proposed rolldown on its own: #143 bumped it to 1.3.1, and the only fix was a manual revert to 1.2.14, which left that PR with no diff.

This adds a packageRules entry that disables Renovate updates for rolldown, with the reason in its description, and lists rolldown with the other disabled updates under Bot Pull Requests in CONTRIBUTING.md. The pin keeps moving with a vite-plus upgrade, by the maintainer in the vite-plus toolchain PR (as in #78).

No shipped file changes, so no changeset.

Validation

  • npx --package renovate@latest -- renovate-config-validator --strict renovate.json: Config validated successfully against 1 file(s).
  • Pre-commit hook: repo-checks repository, check-doc-translations, check-conventions, check-layers, and the format check all ok.

Risks

enabled: false also stops Renovate's OSV security PRs for rolldown (the security rule forces only rangeStrategy, so it does not re-enable a dependency disabled by a package rule). A rolldown advisory is then caught only by the release audit (--audit-level=high), and the fix arrives through a vite-plus upgrade; CONTRIBUTING.md now says so. A standalone rolldown security PR could not pass the CLI build anyway.

apps/web pins rolldown to the vite-plus core's bundledVersions.rolldown,
and the CLI build fails while the pin differs. Renovate's minor/patch
group still proposed rolldown on its own (1.3.1), which could only be
reverted by hand. Disable rolldown updates; the maintainer moves the pin
in the vite-plus toolchain PR, as CONTRIBUTING already requires.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@PerfectPan
PerfectPan force-pushed the chore/renovate-rolldown branch from 7ff5eff to 12e28ad Compare November 17, 2026 12:10
@PerfectPan
PerfectPan merged commit 76d7ff9 into main Nov 17, 2026
7 checks passed
@PerfectPan
PerfectPan deleted the chore/renovate-rolldown branch November 17, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant