Repository navigation
ci(deps): close the pending loop and stop bogus node updates - #34
Merged
Merged
Conversation
Renovate defaults to prCreation pending: it pushes the update branch and only opens the PR once status checks pass. The shrinkwrap workflow only listened for pull_request events, so the pre-PR branch never got its rush update, CI never reported, and the PR could wait forever. Also listen for pushes to renovate/** branches and key concurrency, checkout and branch naming off github.head_ref || github.ref_name so both events share one lane. The dashboard also proposed node.js runtime updates that do not belong here: the runtime is pinned in lockstep across .node-version, rush.json nodeSupportedVersionRange and the workflows, and the old Dependabot config never touched it. Disable the node-version datasource and engines updates to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two follow-ups to #32, both observed on the first live Renovate run (dashboard #33):
prCreation: pending— it pushes the update branch and waits for status checks before opening the PR. The shrinkwrap workflow only listened forpull_requestevents, so the pre-PR branch never got itsrush update, CI never reported, and the PR could wait forever. Add apushtrigger forrenovate/**branches, and key concurrency/checkout/branch naming offgithub.head_ref || github.ref_nameso both events share one lane.update node.js to >=24.22.2andto v26while.node-versionpins26. The runtime is deliberately pinned in lockstep across.node-version,rush.jsonnodeSupportedVersionRangeand the workflows, and the old Dependabot config never touched it — disable thenode-versiondatasource andengines/devEngines.runtimeupdates, matching the agent-task-loop config.Validation
renovate.jsonparses as JSONC (comment-aware check); workflow YAML parsesvite-plus toolchainupdate from the dashboard: branch push → shrinkwrap commit → CI re-dispatch → green → PR opens