Skip to content

ci(deps): close the pending loop and stop bogus node updates - #34

Merged
PerfectPan merged 1 commit into
mainfrom
ci/renovate-followups
Nov 13, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
ci/renovate-followups

Conversation

@PerfectPan

Copy link
Copy Markdown
Owner

Summary

Two follow-ups to #32, both observed on the first live Renovate run (dashboard #33):

  • Pending-PR deadlock. Renovate defaults to prCreation: pending — it pushes the update branch and waits for status checks before opening the PR. The shrinkwrap workflow only listened for pull_request events, so the pre-PR branch never got its rush update, CI never reported, and the PR could wait forever. Add a push trigger for renovate/** branches, and key concurrency/checkout/branch naming off github.head_ref || github.ref_name so both events share one lane.
  • Bogus node.js updates. The dashboard proposed update node.js to >=24.22.2 and to v26 while .node-version pins 26. The runtime is deliberately pinned in lockstep across .node-version, rush.json nodeSupportedVersionRange and the workflows, and the old Dependabot config never touched it — disable the node-version datasource and engines/devEngines.runtime updates, matching the agent-task-loop config.

Validation

  • renovate.json parses as JSONC (comment-aware check); workflow YAML parses
  • End-to-end pending loop verified after merge by un-pending the vite-plus toolchain update from the dashboard: branch push → shrinkwrap commit → CI re-dispatch → green → PR opens

Renovate defaults to prCreation pending: it pushes the update branch and only
opens the PR once status checks pass. The shrinkwrap workflow only listened
for pull_request events, so the pre-PR branch never got its rush update, CI
never reported, and the PR could wait forever. Also listen for pushes to
renovate/** branches and key concurrency, checkout and branch naming off
github.head_ref || github.ref_name so both events share one lane.

The dashboard also proposed node.js runtime updates that do not belong here:
the runtime is pinned in lockstep across .node-version, rush.json
nodeSupportedVersionRange and the workflows, and the old Dependabot config
never touched it. Disable the node-version datasource and engines updates to
match.
@PerfectPan
PerfectPan merged commit afc810c into main Nov 13, 2026
6 checks passed
@PerfectPan
PerfectPan deleted the ci/renovate-followups branch November 13, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant