Skip to content

ci(checks): run duplicate detection in verify - #83

Merged
PerfectPan merged 1 commit into
mainfrom
ci/duplicates-gate
Nov 18, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
ci/duplicates-gate

Conversation

@PerfectPan

Copy link
Copy Markdown
Owner

Summary

  • Run the existing pnpm duplicates check in pnpm verify, which contributors and PR CI both use. The shared lint config sets the threshold to zero, so any reported duplicate fails verification. The scan on main at ef8788c found zero clones.
  • Update the two repository test assertions that pin the shared verify command, and document the gate alongside the report-only pnpm duplicates:audit.
  • fix: drop the premature duplicates gate #81 proposed removing this script; it will be closed in favor of this change.

Validation

  • gh repo-checks repository, gh repo-checks pr-title "ci(checks): run duplicate detection in verify", and gh repo-checks pr-body pr-body.md passed.
  • pnpm install --frozen-lockfile, pnpm fmt, pnpm lint, and pnpm typecheck passed.
  • pnpm verify exited 0. It reported Found 0 clones., passed all 854 tests in 157 files, built the CLI, and printed check-package: ok (rss-summary/rivus-plugin).
  • Ran cp src/kernel/time.ts src/kernel/dup-probe.ts followed by pnpm duplicates. The scan reported one 125-line clone and exited 1. After rm src/kernel/dup-probe.ts, the scan reported Found 0 clones. and exited 0.
  • pnpm test:coverage passed on an unchanged rerun with 854/854 tests and 92.23% line coverage. The first run exited 1 on the Grok timeout snapshot (expected one invocation, observed zero). The same command passed on clean main. No snapshot was updated.

Run the zero-threshold duplicate check alongside the existing local and
PR checks. Update both assertions that pin the shared verify command.

Generated with Codex

Co-Authored-By: Codex <noreply@openai.com>
@PerfectPan
PerfectPan merged commit fa68b5a into main Nov 18, 2026
5 checks passed
@PerfectPan
PerfectPan deleted the ci/duplicates-gate branch November 18, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant