Repository navigation
ci(checks): run Knip during verification - #84
Merged
Merged
Conversation
Generated with Codex Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the existing
pnpm knipscript between duplicate detection and tests inpnpm verify, the command used by the PR Verify job. The shared lint-config Knip rules fail verification on unused files, exports, or dependencies, as well as configuration and tag hints. Update both tests that assert the full verify command and the existing contributor checklists.Validation
mainatfa68b5a,pnpm knipexited 0.pnpm knip:productionexited 1 with 4 unused files, 93 unused exports, and 16 unused exported types. Production mode remains available as a separate script.src/knip-probe.tsexporting a function.pnpm knipexited 1 and listed that file underUnused files (1). After removing the file, the same command exited 0.pnpm install --frozen-lockfile,pnpm fmt, andpnpm lintpassed. The lockfile had no diff.pnpm verifypassed layout, format/lint/type checks, the duplicate gate (0 clones), Knip, all 854 tests, the TypeScript build, and the installed-package check.pnpm duplicates:auditexited 0 with 186 clones under the broader reporting profile.pnpm test:coveragepassed all configured coverage thresholds.gh repo-checks repository,gh repo-checks pr-title "ci(checks): run Knip during verification", andgh repo-checks pr-body <body-file>passed.