Skip to content

ci(checks): run Knip during verification - #84

Merged
PerfectPan merged 1 commit into
mainfrom
ci/knip-gate
Nov 18, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
ci/knip-gate

Conversation

@PerfectPan

Copy link
Copy Markdown
Owner

Summary

Run the existing pnpm knip script between duplicate detection and tests in pnpm verify, the command used by the PR Verify job. The shared lint-config Knip rules fail verification on unused files, exports, or dependencies, as well as configuration and tag hints. Update both tests that assert the full verify command and the existing contributor checklists.

Validation

  • On main at fa68b5a, pnpm knip exited 0. pnpm knip:production exited 1 with 4 unused files, 93 unused exports, and 16 unused exported types. Production mode remains available as a separate script.
  • Created an unreferenced src/knip-probe.ts exporting a function. pnpm knip exited 1 and listed that file under Unused files (1). After removing the file, the same command exited 0.
  • pnpm install --frozen-lockfile, pnpm fmt, and pnpm lint passed. The lockfile had no diff.
  • pnpm verify passed layout, format/lint/type checks, the duplicate gate (0 clones), Knip, all 854 tests, the TypeScript build, and the installed-package check. pnpm duplicates:audit exited 0 with 186 clones under the broader reporting profile.
  • pnpm test:coverage passed all configured coverage thresholds.
  • gh repo-checks repository, gh repo-checks pr-title "ci(checks): run Knip during verification", and gh repo-checks pr-body <body-file> passed.

Generated with Codex

Co-Authored-By: Codex <noreply@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant