Repository navigation
fix(config): fail loudly when an explicit feed file is missing - #87
Merged
PerfectPan merged 2 commits intoNov 18, 2026
Merged
Conversation
claude.dev publishes a first-party blog for the Claude Code team (Addy Osmani and others) and exposes a native RSS 2.0 feed at /rss.xml that the article pages advertise through rel=alternate. Adding it to the personal subscription registry means the 09:00 digest reads it without any page-source adapter or packaging change.
A configured `RSS_FEEDS_FILE` or `--file` that does not exist silently returned no subscriptions, so a broken deployment path produced an empty digest that is indistinguishable from "nothing was published today". The industry registry already threw in the same situation; this makes the personal registry match it. The implicit default (`feeds.json` in the working directory) still resolves to an empty list, so running from a directory without a registry keeps working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadFeedSubscriptionsreturned[]when a configuredRSS_FEEDS_FILE(or--file) did not exist. That silently turns a broken deployment path into an empty digest that looks identical to "nothing was published today" — the exact failure mode we hit when the running daemon pointed at a stale checkout.Feed subscription file does not exist: <path>when the path was explicitly configured, mirroring whatloadIndustrySourcesalready does forINDUSTRY_SOURCES_FILE/INDUSTRY_FEEDS_FILE.feeds.jsonresolved from the working directory) still yields an empty list, so running the CLI from an unrelated directory keeps working.Validation
pnpm checkclean (401 files formatted; 379 files linted and typed with no errors).src/app/config/env.test.ts: 24 passed, including the newrejects an explicit feed subscription file that does not exist.856 passed, with the single pre-existing environment failuresrc/app/products/subscriptions/flow.test.ts > keeps RSS candidates when GitHub Home is unavailable(5s timeout, also fails on unmodifiedmainhere).feeds.jsoninto its temp root, so no golden snapshot changes.Risks
RSS_FEEDS_FILEnow fail the run instead of delivering an empty digest. That is the intent, but the deployed runtime.env.localmust point at an existing file before this build ships — it currently does (/Users/nyx/.rivus/rss-summary/feeds.json).