Skip to content

fix(config): fail loudly when an explicit feed file is missing - #87

Merged
PerfectPan merged 2 commits into
PerfectPan:mainfrom
nyx-cell:codex/reject-missing-feed-file
Nov 18, 2026
Merged

PerfectPan merged 2 commits into
PerfectPan:mainfrom
nyx-cell:codex/reject-missing-feed-file

Conversation

@nyx-cell

Copy link
Copy Markdown
Contributor

Summary

  • loadFeedSubscriptions returned [] when a configured RSS_FEEDS_FILE (or --file) did not exist. That silently turns a broken deployment path into an empty digest that looks identical to "nothing was published today" — the exact failure mode we hit when the running daemon pointed at a stale checkout.
  • The function now throws Feed subscription file does not exist: <path> when the path was explicitly configured, mirroring what loadIndustrySources already does for INDUSTRY_SOURCES_FILE / INDUSTRY_FEEDS_FILE.
  • The implicit default (feeds.json resolved from the working directory) still yields an empty list, so running the CLI from an unrelated directory keeps working.
  • One unit test covers the new failure and its message.

Validation

  • pnpm check clean (401 files formatted; 379 files linted and typed with no errors).
  • src/app/config/env.test.ts: 24 passed, including the new rejects an explicit feed subscription file that does not exist.
  • Full suite: 856 passed, with the single pre-existing environment failure src/app/products/subscriptions/flow.test.ts > keeps RSS candidates when GitHub Home is unavailable (5s timeout, also fails on unmodified main here).
  • Golden harness already writes a real feeds.json into its temp root, so no golden snapshot changes.

Risks

  • Deployments that relied on a typed-but-wrong RSS_FEEDS_FILE now fail the run instead of delivering an empty digest. That is the intent, but the deployed runtime .env.local must point at an existing file before this build ships — it currently does (/Users/nyx/.rivus/rss-summary/feeds.json).

claude.dev publishes a first-party blog for the Claude Code team (Addy Osmani and others) and exposes a native RSS 2.0 feed at /rss.xml that the article pages advertise through rel=alternate. Adding it to the personal subscription registry means the 09:00 digest reads it without any page-source adapter or packaging change.
A configured `RSS_FEEDS_FILE` or `--file` that does not exist silently returned
no subscriptions, so a broken deployment path produced an empty digest that is
indistinguishable from "nothing was published today". The industry registry
already threw in the same situation; this makes the personal registry match it.

The implicit default (`feeds.json` in the working directory) still resolves to
an empty list, so running from a directory without a registry keeps working.
@PerfectPan
PerfectPan merged commit 9cdde62 into PerfectPan:main Nov 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants