Skip to content

Feature/ci pipeline#1

Merged
PeriodicallyZoneOut merged 3 commits into
mainfrom
feature/ci-pipeline
Apr 29, 2026
Merged

Feature/ci pipeline#1
PeriodicallyZoneOut merged 3 commits into
mainfrom
feature/ci-pipeline

Conversation

@PeriodicallyZoneOut

Copy link
Copy Markdown
Owner

Task 1

Copilot AI review requested due to automatic review settings April 29, 2026 16:51
@PeriodicallyZoneOut PeriodicallyZoneOut merged commit a06a9ab into main Apr 29, 2026
67 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new GitHub Actions workflow intended to act as a central CI pipeline for this multi-module Maven repo by detecting which top-level Maven modules changed and then running tests/builds only for those modules (or for all modules when shared config changes).

Changes:

  • Introduces .github/workflows/ci-pipeline.yml with a detect-changes job that builds a dynamic matrix of changed Maven modules.
  • Runs mvn test and mvn package -DskipTests per-module using a matrix strategy, and uploads JUnit XML reports as artifacts.
  • Adds a ci-gate job to consolidate job outcomes into a single pass/fail signal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


permissions:
contents: read
actions: write

Copilot AI Apr 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow requests actions: write at the workflow level, which grants a broader token scope to every job than necessary. To follow least-privilege, restrict elevated permissions to only the job/step that needs it (e.g., artifact upload) and keep other jobs at contents: read (or omit permissions to use the default minimal set).

Suggested change
actions: write

Copilot uses AI. Check for mistakes.
Comment on lines +6 to +9
- "**"
pull_request:
branches:
- "main"

Copilot AI Apr 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow triggers on all pushes (branches: '**') and on every PR targeting main without any paths filter. Given the repo already has many module-specific *-ci.yaml workflows with path filters, this new pipeline will run in addition to them for the same PRs/commits, increasing CI load and duplicate signal. Consider narrowing triggers (add paths/paths-ignore, limit branches, or disable/replace the per-module workflows) so checks remain intentional and predictable.

Suggested change
- "**"
pull_request:
branches:
- "main"
- "main"
paths:
- "pom.xml"
- "**/pom.xml"
- "**/src/**"
pull_request:
branches:
- "main"
paths:
- "pom.xml"
- "**/pom.xml"
- "**/src/**"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants