Feature/setup gitleaks#5
Closed
duongtronghoa6a-debug wants to merge 8 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces PR-time secret scanning via Gitleaks and extends the CI pipeline to generate/upload JaCoCo coverage artifacts and produce a consolidated test/coverage summary, alongside some project workflow documentation and Maven wrapper additions for specific modules.
Changes:
- Add a
pull_requestGitleaks workflow targetingmainanddev. - Extend
.github/workflows/ci-pipeline.ymlwith coverage detection, JaCoCo report generation, threshold enforcement, artifacts, and a “Test Summary” job. - Add JaCoCo Maven plugin configuration to the root
pom.xml, plus module-localmvnwscripts and internal planning/checklist docs.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
pom.xml |
Adds JaCoCo plugin under <build><plugins> (currently duplicating existing pluginManagement config). |
mock-secret.txt |
Adds a mock credential-like string intended to test Gitleaks. |
cart/mvnw |
Adds Maven wrapper shell script for the cart module. |
backoffice-bff/mvnw |
Adds Maven wrapper shell script for the backoffice-bff module. |
WORK_ASSIGNMENT.md |
Adds internal team assignment/coverage tracking notes. |
WORKLOAD_CHECKLIST.md |
Adds internal CI/CD progress checklist. |
.github/workflows/gitleaks.yml |
New PR-triggered Gitleaks workflow. |
.github/workflows/ci-pipeline.yml |
Adds checks permission, coverage reporting/enforcement steps, artifacts, and a test-summary job; updates CI gate dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+424
to
+446
| <version>${jacoco-maven-plugin.version}</version> | ||
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>prepare-agent</goal> | ||
| </goals> | ||
| </execution> | ||
| <execution> | ||
| <id>report</id> | ||
| <phase>verify</phase> | ||
| <goals> | ||
| <goal>report</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| <configuration> | ||
| <excludes> | ||
| <exclude>com/yas/**/*Application.class</exclude> | ||
| <exclude>com/yas/**/config/**</exclude> | ||
| <exclude>com/yas/**/exception/**</exclude> | ||
| <exclude>com/yas/**/constants/**</exclude> | ||
| </excludes> | ||
| </configuration> |
Comment on lines
+1
to
+2
| # Dòng này cố tình chứa secret giả để test Gitleaks trong quá trình làm đồ án | ||
| AWS_ACCESS_KEY_ID=AKIAIOSFODNN7EXAMPLE |
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - uses: gitleaks/gitleaks-action@v2 |
Comment on lines
425
to
429
| runs-on: ubuntu-latest | ||
| needs: [detect-changes, test, build] | ||
| needs: [detect-changes, test, build, test-summary] | ||
| if: always() | ||
| steps: | ||
| - name: Evaluate results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.