naming: add affix pressure rule#43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Repeated naming affixes such as
parse_can reveal structure that is stillliving inside identifiers. The new affix-pressure rule needs a conservative
cross-language implementation and a real self-check loop that treats warnings
as refactoring input instead of suppressing them with a higher threshold.
What
core/naming/affix-pressureover existing function and method name facts.min_occurrences=15and config override support.analysis without adding language-specific semantics.
parse_*while naming private helpersby structure;
Tests
cargo fmt --all --checkcargo test --locked -p flavor-plugin-svelte -p flavor-plugin-vue -p flavor-plugin-typescriptcargo clippy --locked --workspace --all-targets -- -D warningscargo run --locked -p flavor-cli -- check --root . --config flavor.tomlcargo test --locked --workspace