style/refactor: unbreak the lint gate on main (cargo fmt after #4853 + body_stmt.rs file-size split)#4855
Merged
Merged
Conversation
#4853 merged with formatting that the current stable rustfmt (1.9.0 / rustc 1.96.0, what CI's dtolnay/rust-toolchain@stable installs) rejects, so the required 'lint' check now fails on every PR's merge ref regardless of its content (first seen on wt-clm-parity at 18:51Z, then worktree-fix-4851/#4854). Formatting-only change, no code edits.
…tmt.rs (file-size gate) body_stmt.rs hit 2038 lines on main (limit 2000), so the lint job's file-size gate fails every PR even after the fmt fix. Move the self-contained for-await/for-of head-expression detection predicates (ReadableStream / Node Readable / readline / fs.Dir) plus the IteratorClose helpers into body_stmt/detect.rs, following the existing body_stmt/for_await.rs split pattern. Pure code motion, no behavior change; body_stmt.rs is now 1826 lines.
proggeramlug
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required
lintcheck currently fails on every PR's merge ref, for two independent reasons introduced by recent merges:cargo fmt --all -- --check: fix(runtime): class subclass + async-method + definition test262 tail #4853 landed with formatting that the current stable rustfmt (1.9.0 / rustc 1.96.0, what CI'sdtolnay/rust-toolchain@stableinstalls) rejects — 4 files (runtime_decls/objects.rs,closure/mod.rs,object/class_registry.rs,object/descriptors.rs). Commit 1 is purecargo fmt --alloutput.crates/perry-hir/src/lower_decl/body_stmt.rsis at 2038 lines on main (limit 2000). Commit 2 moves the self-contained for-await/for-of head-expression detection predicates (ReadableStream / Node Readable / readline / fs.Dir) + the IteratorClose helpers intobody_stmt/detect.rs, following the existingbody_stmt/for_await.rssplit pattern — pure code motion, no behavior change; body_stmt.rs → 1826 lines.First seen on the
wt-clm-parityPR run at 18:51Z, then on #4854 — both fail onlylint, with diffs exclusively in files those PRs don't touch. Verified locally:cargo fmt --all -- --check+./scripts/check_file_size.sh+cargo test -p perry-hirall green.Once this merges, re-running lint on open PRs (or rebasing them) goes green.
No version bump / changelog (style/refactor-only; happy to drop if you'd rather fold into your next admin push).