-
-
Notifications
You must be signed in to change notification settings - Fork 132
fix(compile,runtime): 14 walls from Next.js standalone compile validation #5050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e71c161
fix(compile,runtime): 14 walls from Next.js standalone compile valida…
d554985
fix(hir,codegen,runtime): function-nested class capture suite — vendo…
0bf6efa
fix(hir,codegen,runtime): wall #21 — forward class refs, static-metho…
d859960
fix(codegen): pack rest/arguments params on the ctor symbol-call path
24080ec
fix(hir): append capture args to New sites lowered before class regis…
9e05cdb
fix(cjs_wrap): require() of an unresolvable specifier throws MODULE_N…
e09e9f1
fix(compile,runtime): wall #24/#25 — webpack inner-module class inter…
2a5671f
fix(hir): hoist generator/async-generator FnDecls inside nested funct…
2a9caa1
fix(resolve): append extension for dotted specifiers instead of repla…
af92965
fix(codegen): apply entry-module process.env literals before eager mo…
c1a940d
fix(runtime): native function `name` is non-enumerable (for-in / copy…
3a850ec
feat(compile): lazy function-local require — defer init like Node (Ne…
3c5f8e0
fix(runtime,compile): address CodeRabbit review on #5050
b929e10
style: rustfmt pass over #5050 walls + review-fix files
a48768d
refactor(compile): extract native-addon detection to collect_modules/…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Class-capture snapshots are keyed too coarsely.
RegisterClassCaptureswrites the snapshot intoCLASS_CAPTURE_VALUES[class_id], andClassCaptureValuelater reads it back with the same compile-timeclass_id. That means the second evaluation of a nested class overwrites the first one, so previously returned/exported class values start constructing or rebinding statics against the newest closed-over environment. A shape likeconst A = make(1); const B = make(2); A.staticGet()will read2here. This needs to be keyed off the concrete class value / fresh class object, not the shared template id.🤖 Prompt for AI Agents