test(hir): fix cheerio_call_rewrite compile on main (missing byte_offset after #5250)#5266
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThree ChangesCheerio Call Rewrite Test Fixture
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…e compile after #5250 (#5288) #5250 added `Expr::Call.byte_offset` but missed the `Expr::Call { .. }` initializers in perry-codegen-arkts's tests (3 in src/tests.rs, 3 in tests/phase2_full_app_smoke.rs). perry-codegen-arkts isn't built by the gating `cargo-test` job, only by the informational `harmonyos-smoke` job (continue-on-error), so this E0063 sat red on main — and on every open PR — without blocking anything. Mirrors the #5266 cheerio fix. After: `cargo test -p perry-codegen-arkts --lib` (111 passed) and `--test phase2_full_app_smoke` (2 passed) both green. No version/CHANGELOG/Cargo.lock edits. Co-authored-by: Ralph Küpper <ralph2@skelpo.com>
#5250 added
Expr::Call.byte_offsetbut missed updatingcrates/perry-hir/tests/cheerio_call_rewrite.rs, socargo test -p perry-hirfails to compile onmain(error[E0063]: missing field byte_offset×3). This addsbyte_offset: 0to the 3Expr::Callconstructions. Test compiles + passes. No src changes.Summary by CodeRabbit
Tests
byte_offsetfield.User Impact