-
-
Notifications
You must be signed in to change notification settings - Fork 132
codegen: split large modules into N codegen units (bound clang peak memory) (#5391) #5407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9eec218
feat(codegen): split large modules into N codegen units (#5391)
c60e5ae
fix(codegen): emit each function symbol once (duplicate-name collision)
ea55455
perf(codegen): balance codegen units by estimated byte size (#5391)
7937a2c
perf(codegen): split the string-pool init into chunk functions (#5391)
05fd8ef
style: cargo fmt (codegen string_pool/function/linker/module)
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 7863
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 1664
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 1884
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 4435
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 914
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 619
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 5531
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 39
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 1075
Add PERRY_SAVE_LL check to n_units decision logic.
The code comment at line 2532 states that both
emit_ir_onlyandPERRY_SAVE_LLshould use the single-text path, but the n_units decision at lines 2535–2537 only checksemit_ir_only. WhenPERRY_SAVE_LLis set, the code incorrectly proceeds to codegen splitting instead of taking the single-text path where PERRY_SAVE_LL is actually handled (line 2558). This causes the directory to be never populated because the split path returns early without reaching the PERRY_SAVE_LL save logic.Additionally, cross-compilation with splitting should be gated: when cross-compiling (no
--targetflag override from host),ld -rat line ~320 uses the host linker by default, which may not support the target object format. Passopts.target.is_some()into the n_units decision to force single-unit mode.🔧 Proposed fix
🤖 Prompt for AI Agents