Open
Conversation
- no more hardcoded paths in the project - more versatile .gitignore (works up to VS2017) - include detours.lib directly in the project - remove x64 platform (Dark Souls is 32 bit) - remove Debug platform (the readme explicitly states this should not be used) - add filters file to categorize source files - added direction to DirectX SDK in the source (at the place it would error)
Contributor
|
@mrexodia This is excellent! I've wanted to make this kind of cleanup, but didn't know how to do it properly. I've rebased my conflicting PR on top of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This conflicts/replaces pull request #33 I changed the configuration to VS2012 because that's the lowest version I could get this project to compile on.
This change is