Skip to content

Implement native robust Python .xdf exporting#2

Open
CommanderPho wants to merge 1 commit into
developfrom
fix-xdf-writing-17293162538117647457
Open

Implement native robust Python .xdf exporting#2
CommanderPho wants to merge 1 commit into
developfrom
fix-xdf-writing-17293162538117647457

Conversation

@CommanderPho

Copy link
Copy Markdown
Collaborator

Implemented xdf_writer.py module mimicking standard LabRecorder .xdf encoding. Updated logger_app.py export logic to bypass MNE. Generated robust automated unit tests utilizing pyxdf.


PR created automatically by Jules for task 17293162538117647457 started by @CommanderPho

Replaced the hacky MNE `.fif` to XDF conversion with a native `xdf_writer.py` implementation that complies directly with the App-LabRecorder C++ specification logic. Added unit tests for XDF programmatic generation.

Co-authored-by: CommanderPho <962210+CommanderPho@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant