Repository navigation
Locations Supertype Table, Related Tables, and Location Subtype Tables - #136
Open
Norberttony wants to merge 9 commits into
Open
Norberttony wants to merge 9 commits into
Norberttony wants to merge 9 commits into
Conversation
Norberttony
commented
Oct 26, 2026
Norberttony
commented
Contributor
- Added location supertype with all of its related tables and all of its subtypes.
- Changed buildings table to be a subtype of locations
- Moved update logging mixin from Building to Location
- Added a LOSSY db migration (never run with real user data) where the downgrade might not actually work lol
… (buildings.id -> buildings.location_id and locations.location_id -> locations.id)
DJFreer92
marked this pull request as ready for review
October 27, 2026 02:25
DJFreer92
enabled auto-merge (squash)
October 27, 2026 02:25
DJFreer92
requested changes
Oct 27, 2026
Member
There was a problem hiding this comment.
I think the enum should have int values to reduce data redundancy in the database
| from backend.schema.special_operating_hours import SpecialOperatingHours | ||
|
|
||
|
|
||
| class Location(UpdateLoggingMixin, Base): |
Member
There was a problem hiding this comment.
I think this can use the ID mixin
DJFreer92
requested changes
Oct 27, 2026
Member
There was a problem hiding this comment.
Locations is probably too broad for a single feature
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.