This repository was archived by the owner on Jul 31, 2026. It is now read-only.
Repository navigation
Daniel_F_17_Offset-Pattern - #18
Merged
Merged
Conversation
…rage command to package.json
doubleshotofmika
approved these changes
Sep 22, 2025
doubleshotofmika
left a comment
doubleshotofmika
left a comment
There was a problem hiding this comment.
No obvious issues. Readme is fine
Cat-Brain
self-requested a review
September 22, 2025 23:24
Cat-Brain
approved these changes
Sep 22, 2025
Cat-Brain
left a comment
Cat-Brain
left a comment
Contributor
There was a problem hiding this comment.
I spent a long time thinking through the logic and style and it all seems logical and accordig to the style guides we are following. However, I do have some ideas on how to refine this to work better later but that's not all too important and I think it would be a better spending of our time to do such once we switch to graph theory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.