Skip to content
This repository was archived by the owner on Jul 31, 2026. It is now read-only.

Daniel_F_24_Set-up-global-styles - #26

Merged
DJFreer92 merged 87 commits into
mainfrom
Daniel_F_24_Set-up-global-styles
Jan 30, 2026
Merged

DJFreer92 merged 87 commits into
mainfrom
Daniel_F_24_Set-up-global-styles

Conversation

@DJFreer92

@DJFreer92 DJFreer92 commented Oct 4, 2025 •

Copy link
Copy Markdown
Member
  • Global styles
  • Restructured src directory to have client code in a separate sub-directory
  • Moved index.html to the src directory and improved vite and tsconfig config settings

…oject description

Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
…olve npm run lint error

Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
…sconfig

Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
…bal-styles

Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
@DJFreer92
DJFreer92 requested a review from a team October 4, 2025 23:32
@DJFreer92
DJFreer92 requested a review from a team as a code owner October 4, 2025 23:32
@DJFreer92
DJFreer92 enabled auto-merge (squash) October 4, 2025 23:32
@DJFreer92 DJFreer92 self-assigned this Oct 4, 2025
@DJFreer92 DJFreer92 linked an issue Oct 4, 2025 that may be closed by this pull request
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
@DJFreer92
DJFreer92 requested a review from Copilot October 21, 2025 00:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR establishes a comprehensive global styling system and React component library for the Chess Variant Simulator application. The changes include restructuring the project to separate client and server code, implementing a complete SCSS-based design system with reusable components, and adding corresponding unit tests.

Key Changes:

  • Implemented a complete SCSS design system with abstracts (variables, mixins, functions), base styles, and 15+ styled components
  • Created 21 reusable React components with TypeScript including forms, navigation, modals, alerts, and UI elements
  • Added comprehensive unit test coverage for all React components using Vitest and React Testing Library
  • Restructured project to separate client code into src/client subdirectory and moved index.html to src
  • Updated build configuration (Vite, TypeScript) with path aliases and improved settings

Reviewed Changes

Copilot reviewed 81 out of 165 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
vitest.config.ts Added jsdom environment, test setup file, and path aliases for client/server/shared code
vite.config.js Configured new root directory, path aliases, and output directory for restructured project
tsconfig.*.json Updated include paths to reflect new directory structure
src/client/styles/ Complete SCSS architecture with variables, mixins, component styles, and utility classes
src/client/components/ 21 React components (Alert, Badge, Button, Card, Form elements, Modal, etc.)
tests/client/components/ Comprehensive unit tests for all React components
src/index.html Moved HTML entry point to src directory with React app mounting
package.json Added dependencies: classnames, normalize.css, @testing-library/jest-dom, jsdom

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread eslint.config.js Resolved
Comment thread src/client/components/NavBar.tsx Resolved
Comment thread tests/client/components/Card.spec.tsx Resolved
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
@DJFreer92
DJFreer92 requested a review from Copilot October 21, 2025 01:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 81 out of 165 changed files in this pull request and generated 8 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/client/styles/utils/_utilities.scss Resolved
Comment thread vitest.config.ts Resolved
Comment thread src/client/styles/utils/_utilities.scss Resolved
Comment thread src/client/components/Toggle.tsx Resolved
Comment thread src/client/components/Notification.tsx Resolved
Comment thread src/index.html Resolved
Comment thread eslint.config.js Resolved
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>
Signed-off-by: Daniel Freer <deletes_minimal.0w@icloud.com>

@Norberttony Norberttony left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah idk seems ok

Image

@DJFreer92
DJFreer92 merged commit 3fa1651 into main Jan 30, 2026
2 checks passed
@DJFreer92
DJFreer92 deleted the Daniel_F_24_Set-up-global-styles branch January 30, 2026 00:11
@Norberttony

Copy link
Copy Markdown
Contributor

wait no undo

@Norberttony

Copy link
Copy Markdown
Contributor

i didnt realize it had react and scss hang on

@Norberttony

Copy link
Copy Markdown
Contributor

I was too visually distracted by the funny cats

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set Up Global Styles

3 participants