Feature/qr code scaling#1567
Open
Foxobot wants to merge 14 commits into
Open
Conversation
Contributor
npm run format
npm run composer:cgl |
3371b46 to
baf2954
Compare
Collaborator
|
Addressed the review findings on this branch. Fixed:
Tests/validation added:
Intentional behavior choice:
Latest commit on the PR branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
fixes issue #1547
What changes did you make? (Give an overview)
I added 3 new Config Parameters into print tree:
- absolute: nothing changes, behaviour of qr-code size and offset as before
- relative: new parameters qrRelativeSize and qrRelativeOffset are used to scale and place the qr code on print.
Inserted relative scaling and positioning into src/Image.php. Only active when qrPositionMode=relative
Is there anything you'd like reviewers to focus on?
Maybe there is a more elegant way to have the two sets of parameters in the config page (for example not showing the absolute parameters when relative is selected?)
AI used to create this Pull Request?
AI was used to navigate through the project to find the files that need changes. AI was used to give an hint how the changes can be made minimal-invasive to the existing code.