Add saturation slider#2324
Open
spacey-sooty wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
frontend
spacey-sooty
force-pushed
the
add-saturation-slider
branch
from
1176bd3 to
639e622
Compare
spacey-sooty
force-pushed
the
add-saturation-slider
branch
from
b64a5af to
6d61d77
Compare
mcm001
reviewed
Mar 4, 2026
|
|
||
| @Override | ||
| public void setSaturation(double saturation) { | ||
| // TODO need to implement this on JNI side as well |
Contributor
There was a problem hiding this comment.
Or we can leave this todo/issue open, and only support USB cameras?
Member
Author
There was a problem hiding this comment.
I just realised I have photon bench access so I can test this now. I will test this on like Tuesday or Wednesday
Member
Author
There was a problem hiding this comment.
my OS is kinda cooked rn so I can't connect to the bench and I grabbed the wrong limelight from the shop so couldn't test this 💀 I will grab a colour limelight on Friday...
spacey-sooty
force-pushed
the
add-saturation-slider
branch
3 times, most recently
from
b9a8d74 to
2c45e6a
Compare
Resolves PhotonVision#2311 Signed-off-by: Jade Turner <spacey-sooty@proton.me>
spacey-sooty
force-pushed
the
add-saturation-slider
branch
from
2c45e6a to
2acf621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a saturation slider, tested on my laptops in built camera.
Resolves #2311
Meta
Merge checklist: