Increase resolution of camera lost frame#2418
Open
Gold856 wants to merge 1 commit into
Open
Conversation
Contributor
|
I'll also note another option we have while we're stuck on MJPG is to increase the stream quality. But cscore lets clients chose quality anyways |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
The current Camera Lost image is rather low resolution and pixelated, corrupting the shape of the text, and JPEG compression also smudges all the text, making it somewhat hard to read (and not very appealing to look at either). Doubling the resolution removes most of the smudging from JPEG artifacts, and gives enough pixels for the text to be shaped correctly, with the end result being much easier to read and nicer to look at. Bandwidth increases from ~0.08 Mbit/s to ~0.18 Mbit/s, which is likely acceptable for this use case.
Meta
Merge checklist: