Added classes and settings for supporting the new ThriftiestOV9281 Ca…#2478
Open
DoctorFogarty wants to merge 6 commits into
Open
Added classes and settings for supporting the new ThriftiestOV9281 Ca…#2478DoctorFogarty wants to merge 6 commits into
DoctorFogarty wants to merge 6 commits into
Conversation
github-actions
Bot
added
the
backend
…nto ThriftiestCam
mcm001
reviewed
Jun 14, 2026
| super.setUpExposureProperties(); | ||
|
|
||
| // Fix the exposure lower and upper limits. | ||
| // The minimum usable exposure is above the UI default of 20, so |
Contributor
There was a problem hiding this comment.
I wonder if there's a way to choose saner defaults based on camera model, or to use real units like milliseconds here
| // breaks permanently if a YUYV↔MJPEG format switch occurs. | ||
| // Only MJPEG modes (120fps) are usable; YUYV modes are 5-30fps anyway. | ||
| int originalSize = videoModes.size(); | ||
| videoModes.removeIf(m -> m.pixelFormat != PixelFormat.MJPEG); |
Contributor
There was a problem hiding this comment.
OnCameraConnected is the first time video modes can be enumerated but perhaps the code that actually grabs video modes should be the thing to care here instead? Having stables mutate camera state feels like an anti pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds class and settings for the new OV9281 variant introduced by ThriftyBot
https://www.thethriftybot.com/products/thriftiest-cam
Meta
Merge checklist: