Store calibration board measurements in native units#2480
Merged
Conversation
github-actions
Bot
added
frontend
thatcomputerguy0101
force-pushed
the
mm-calibration
branch
from
9ac98f3 to
6c37b9f
Compare
thatcomputerguy0101
force-pushed
the
mm-calibration
branch
2 times, most recently
from
58650d1 to
c319498
Compare
| break; | ||
|
|
||
| case CalibrationBoardTypes.Charuco: | ||
| // TODO: Dynamically generate ChArUco using opencv |
Contributor
Author
There was a problem hiding this comment.
I forgot I left this TODO in here. Dynamic ChArUco generation might be the topic of another PR though.
thatcomputerguy0101
changed the title
| @@ -110,32 +110,32 @@ watchEffect(() => { | |||
| uniqueVideoResolutionIndex.value = currentIndex; | |||
| }); | |||
| const dimensionUnit = ref<"in" | "mm">("in"); | |||
Contributor
Author
There was a problem hiding this comment.
Which unit do we want to be the default?
Contributor
There was a problem hiding this comment.
I only kept it as inches since that's the existing behaviour.
I reckon whatever the default is should match whatever's in the board PDF.
Contributor
Author
|
Drafting this until #2495 is merged, since this PR has some problems that will be less redundant to fix later. |
thatcomputerguy0101
changed the title
Contributor
Author
|
Undrafting this since I think I separated the changes from what #2495 does enough to go in either order. |
thatcomputerguy0101
force-pushed
the
mm-calibration
branch
2 times, most recently
from
83ffdde to
05cf70e
Compare
thatcomputerguy0101
force-pushed
the
mm-calibration
branch
from
05cf70e to
89637e9
Compare
thatcomputerguy0101
changed the title
mcm001
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #2479. Stores calibration measurements in native units on the UI, converting to meters when calibration is requested or inches when a calibration board is generated. Fixes some floating-point rounding problems caused by converting back and forth between the display value and the stored values that interferes with typing measurements with the unit set to
mm.Meta
Merge checklist: