cancel the workflow if build-gradle fails and unblock previously dependent jobs#2525
Merged
Merged
Conversation
samfreund
force-pushed
the
unblock-build-gradle
branch
from
aa9a9aa to
8b15873
Compare
samfreund
force-pushed
the
unblock-build-gradle
branch
from
8b15873 to
7c941ac
Compare
Contributor
|
At the potential cost of eating CI runner time for jobs that would fail, right? |
Member
Author
So yes, but everything gets canceled if the tests fail. Since we don't pay the runner time, I don't think it's any worse than if someone was to commit code that passed the tests. |
Contributor
|
Is it possible for us to later only build for Mac universal? |
mcm001
approved these changes
Jun 30, 2026
mcm001
left a comment
mcm001
left a comment
Contributor
There was a problem hiding this comment.
Need to keep gradle build job I think? I think it hits more targets than just the FAT JAR but maybe fact check me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to wait for build-gradle to run everything else. Thus also sets it up so that if tests fail, we cancel the entire workflow.
This also cuts roughly six minutes off our CI time.