fix(photon-core): correct swapped VID/PID on three Logitech quirk entries#2530
Open
JosephTLockwood wants to merge 1 commit into
Open
fix(photon-core): correct swapped VID/PID on three Logitech quirk entries#2530JosephTLockwood wants to merge 1 commit into
JosephTLockwood wants to merge 1 commit into
Conversation
…ries QuirkyCamera's constructors take (usbVid, usbPid), but three entries were written PID-first: the generic "Logitech HD Webcam" (0x9331, 0x5A3), the C270 (0x825, 0x46D), and the C925-e (0x85B, 0x46D). Since getQuirkyCamera matches on exact VID and PID, these quirks could never fire for the real hardware -- the C270's CompletelyBroken flag and the C925-e's AdjustableFocus support were silently dead. Logitech's vendor ID is 0x046D and ARC International's is 0x05A3, so VID belongs first in each pair. Swap each entry to VID-first and pin the known VID/PID pairs in QuirkyCameraTest, including negative assertions that the swapped order does not match.
github-actions
Bot
added
the
backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three Logitech/ARC entries in the camera quirk table were written product-ID-first, but
QuirkyCameramatches on(usbVid, usbPid). As a result the quirks never fired for the real hardware — the C270'sCompletelyBrokenflag and the C925-e'sAdjustableFocussupport were silently dead.Corrected to VID-first (C270
0x046D/0x0825, C925-e0x046D/0x085B, generic ARC "Logitech HD Webcam"0x05A3/0x9331), withQuirkyCameraTestpinning each VID/PID pair and asserting the swapped order does not match.Meta
Merge checklist: