Skip to content

ship versioning helper with plugin#16

Merged
mcm001 merged 4 commits into
mainfrom
ship-versioning-helper
May 20, 2026
Merged

ship versioning helper with plugin#16
mcm001 merged 4 commits into
mainfrom
ship-versioning-helper

Conversation

@samfreund

Copy link
Copy Markdown
Member

Throughout our upgrade for 2027, we've had to upgrade our versioningHelper across the photonverse. versioningHelper.gradle is the same everywhere, so it makes sense to distribute it in a dep consumed by everything (namely wpilibtools).

@samfreund

Copy link
Copy Markdown
Member Author

Note that this was tested by publishing to maven local, and updating the monorepo to pull in the locally published version. All that's necessary is removing the versioningHelper.gradle file and application, assuming wpilibtools is applied no further chnages should be needed.

@spacey-sooty spacey-sooty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely it makes more sense to actually integrate this in as Java code?

@samfreund samfreund force-pushed the ship-versioning-helper branch from 136c41e to 30af249 Compare May 19, 2026 15:06
@samfreund

Copy link
Copy Markdown
Member Author

@mcm001 can u take a look?

@samfreund

Copy link
Copy Markdown
Member Author

Surely it makes more sense to actually integrate this in as Java code?

Not really, that means we have to do shenanigans to call it from the gradle build for this plugin. Making it a gradle file means we can call it for this one, and whatever we distribute it to.

Comment thread src/main/java/org/photonvision/tools/AssembleNativeResources.java

@mcm001 mcm001 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm I'll let @spacey-sooty approve tho

@mcm001 mcm001 merged commit b6033a2 into main May 20, 2026
26 checks passed
@mcm001 mcm001 deleted the ship-versioning-helper branch May 20, 2026 03:41
@samfreund

Copy link
Copy Markdown
Member Author

For future reference, I also tested building the monorepo with this version and the last version. I saw only trivial differences in build time, so it seems like no regressions have been introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants