ship versioning helper with plugin#16
Conversation
|
Note that this was tested by publishing to maven local, and updating the monorepo to pull in the locally published version. All that's necessary is removing the versioningHelper.gradle file and application, assuming wpilibtools is applied no further chnages should be needed. |
spacey-sooty
left a comment
There was a problem hiding this comment.
Surely it makes more sense to actually integrate this in as Java code?
136c41e to
30af249
Compare
|
@mcm001 can u take a look? |
Not really, that means we have to do shenanigans to call it from the gradle build for this plugin. Making it a gradle file means we can call it for this one, and whatever we distribute it to. |
mcm001
left a comment
There was a problem hiding this comment.
Lgtm I'll let @spacey-sooty approve tho
|
For future reference, I also tested building the monorepo with this version and the last version. I saw only trivial differences in build time, so it seems like no regressions have been introduced. |
Throughout our upgrade for 2027, we've had to upgrade our versioningHelper across the photonverse. versioningHelper.gradle is the same everywhere, so it makes sense to distribute it in a dep consumed by everything (namely wpilibtools).