Testing consistency of parameters update (Python)#327
Open
Mat198 wants to merge 3 commits intoPickNikRobotics:mainfrom
Open
Testing consistency of parameters update (Python)#327Mat198 wants to merge 3 commits intoPickNikRobotics:mainfrom
Mat198 wants to merge 3 commits intoPickNikRobotics:mainfrom
Conversation
Compares values between ROS and GPL
christophfroehlich
requested changes
Mar 21, 2026
Collaborator
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Thank you! Can you fix the failing pre-commit tests please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test aims to verify whether the internal parameter from generate_parameter_library matches the node parameter. This test fails with mapped parameters (
test_update_nested_dynamic_mapandtest_update_map_joint_dof_weight) as related to issue #307. All tests pass on PR #275.Thanks for the amazing package!