fix: remove web_ui compose service stub - #63
Conversation
MoveIt Pro 10.0 removed the web_ui service, so mirroring it here as an empty stub makes docker compose reject the whole project: service "web_ui" has neither an image nor a build context specified: invalid compose project That blocks every command in a fresh workspace made from this template on 10.0. It is the leftover half of #62, which renamed agent_bridge to runtime but left web_ui in place. Removing the stub is a no-op for anyone still on a release that has the service: an empty stub contributes nothing to the merge, so the merged project is byte-identical with or without it.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 SummarySummary by CodeRabbit
WalkthroughThe Compose configuration updates the runtime service description and removes the ChangesCompose configuration cleanup
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The Compose template removes the obsolete empty web UI service stub and updates its runtime documentation, avoiding invalid Compose service definitions without introducing an identified merge-readiness risk. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
The comment still described runtime as the bridge between the Agent and the Web UI. 10.0 removed the Web UI; the frontend is a separately distributed Desktop App that connects to the Runtime. Wording taken verbatim from the runtime service in /opt/moveit_pro/docker-compose.yaml at 10.0.0-rc8, since this file exists to mirror that one. Comment only, no effect on the rendered project.
Problem
MoveIt Pro 10.0 removed the
web_uiservice. This template still mirrors it as an empty stub, so Docker Compose rejects the entire project:Compose validates every service in the merged project, and with nothing left in
/opt/moveit_pro/docker-compose.yamlto merge onto,web_ui: {}is a service with no image and no build context.This blocks every
moveit_procommand in a brand-new workspace created from this template on 10.0, so a first-time user hits it before they can build or run anything. It is the leftover half of #62, which renamedagent_bridge→runtimebut leftweb_uibehind.Services in
/opt/moveit_pro/docker-compose.yamlat10.0.0-rc8:Changes
web_uistub — the fix for the above.runtimecomment — it still read "Starts the MoveIt Pro Agent and the Bridge between the Agent and the Web UI." 10.0 has no Web UI; the frontend is a separately distributed Desktop App that connects to the Runtime. New wording is taken verbatim from theruntimeservice in/opt/moveit_pro/docker-compose.yamlat10.0.0-rc8, since this file exists to mirror that one. Comment only.Verification
Merging the base compose file with this template, before and after:
docker compose configmainservice "web_ui" has neither an image nor a build context specifiedThe comment commit renders a byte-identical project to the commit before it, as expected.
This is safe for older releases
Removing the stub does not change behaviour on a release that still has the service. An empty stub contributes nothing to the merge. Verified by adding an
mcp: {}stub (a service 10.0 does have) and diffing the rendered project with and without it — byte-identical.So this is a strict fix: it unblocks 10.0 and is a no-op anywhere the service still exists.
Found while building a new workspace from this template on
10.0.0-rc8.