Skip to content

Fix legacy MC support #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PimvanderLoos merged 3 commits into from
Jul 12, 2026
Merged

Fix legacy MC support #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fad40ed
Shade ByteBuddy to fix support for versions below MC 1.16.5
PimvanderLoos Jul 12, 2026
480e356
Update XMaterial with Java 8 support
PimvanderLoos Jul 12, 2026
9fa48a1
Fix FakePlayerCreator on 1.11
PimvanderLoos Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,9 @@ updateMirror.sh
**/target/*
*/lib/*
nms_build/


.factorypath
.settings/
bin/
tmp/
1 change: 1 addition & 0 deletions NEXT_RELEASE_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix support for version before MC 1.16.5.
6 changes: 5 additions & 1 deletion core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@
<groupId>net.bytebuddy</groupId>
<artifactId>byte-buddy</artifactId>
<version>${dependency.bytebuddy.version}</version>
<scope>provided</scope>
<scope>compile</scope>
</dependency>

<dependency>
Expand Down Expand Up @@ -408,6 +408,10 @@
<pattern>com.github.Anon8281.universalScheduler</pattern>
<shadedPattern>nl.pim16aap2.bigDoors.lib.universalScheduler</shadedPattern>
</relocation>
<relocation>
<pattern>net.bytebuddy</pattern>
<shadedPattern>nl.pim16aap2.bigDoors.lib.bytebuddy</shadedPattern>
</relocation>
</relocations>
<filters>
<filter>
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/nl/pim16aap2/bigDoors/compatibility/FakePlayerClassGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ private static Map<String, Method> getMethods(Class<?> clz)
*/
private DynamicType.Builder<?> addMethodGetWorld(DynamicType.Builder<?> currentBuilder, Map<String, Method> methods)
{
final Method method = findMethod(Player.class).withName("getWorld").checkInterfaces().get();
final Method method = findMethod(Player.class).findMultiple().atLeast(1).withName("getWorld").checkInterfaces().get().get(0);
final Method target = findMethod(Location.class).withName("getWorld").get();
if (methods.remove(simpleMethodString(method)) == null)
throw new IllegalStateException("Failed to find mapped method: " + method);
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<dependency.maven-source.version>3.4.0</dependency.maven-source.version>
<dependency.maven-surefire.version>3.5.4</dependency.maven-surefire.version>

<dependency.xseries.version>27883fb37a</dependency.xseries.version>
<dependency.xseries.version>f401ec771c</dependency.xseries.version>
<dependency.xseries.groupid>com.github.PimvanderLoos</dependency.xseries.groupid>
</properties>

Expand Down