Skip to content

Add Dominican Republic and Peru lineup - #29

Open
taos15 wants to merge 1 commit into
PiratesIRC:mainfrom
taos15:main
Open

taos15 wants to merge 1 commit into
PiratesIRC:mainfrom
taos15:main

Conversation

@taos15

@taos15 taos15 commented Sep 23, 2026

Copy link
Copy Markdown

Introduce lineups for the Dominican Republic and Peru to enhance the roster options.

@taos15

taos15 commented Sep 23, 2026

Copy link
Copy Markdown
Author

I was going to open a pull request for for the other plugins, like stream_maparr, Channel_maparr, and epg_janitor. Please let me know if you are able to port the lineup to them or if I need to open a new PR on each.

Thank you

@PiratesIRC

Copy link
Copy Markdown
Owner

Thank you for this. Four lineups with a written note on where each channel
came from saves me a lot of work, and I would like to merge it. I ran the
repository checks on your branch and there is one thing that has to change
first, plus one request that would make the pull request much easier to review.

Required: a duplicate channel name in DO_Altice_lineup.json

validate_plugin.py fails, and so does one test:

DO_Altice_lineup.json: duplicate names in 'Nacionales': 'CDN SportsMax' x2

Channels 28 and 37 are both named CDN SportsMax. Two channels with the same
name in one category merge into a single channel when Lineuparr syncs, so the
validator refuses the file.

I think channel 37 should be CDN, the news channel. Your HD category has
CDN HD at 437, and your Claro file has CDN at 37. I am inferring that from
the numbering, though, so please check it against the Altice source, and
check channel 28 as well. If both really are the same channel, remove one of
them.

The Claro and Combined files do not have this problem. Everything else passed:
the rest of the local test suite and the matcher regression check.

Requested: please undo the reformatting of aliases.py

The pull request changes aliases.py by +562 and -91 lines. I loaded both
versions and compared the dictionaries: CHANNEL_ALIASES is identical, and
the only real change is the new DO and PE sections in COUNTRY_ALIASES.
The rest is an automatic formatter splitting existing lists across lines and
removing the blank lines between sections.

Could you restore the existing entries to their original layout and keep only
the two new sections? That makes the change reviewable line by line, and it
avoids merge conflicts with other open work that edits the same file. Wrapping
the new DO and PE entries however you like is fine.

For information, no change needed

  • DO and PE are not in the country list Lineuparr uses to filter streams
    by their country prefix (_KNOWN_COUNTRY_CODES in fuzzy_matcher.py). Your
    DO and PE alias sections still apply, because they are selected from the
    lineup filename. Without the country codes, these lineups keep streams
    tagged with other countries instead of dropping them. I will look at adding
    the codes separately. Adding a code can remove correct streams in a region
    whose providers share channels across borders, so I want to measure it
    first rather than ask you to add it here.
  • Both Dominican Republic source files are dated 2018. That is fine for now,
    since it is the best public list available. If you come across a newer one,
    a later update is welcome.
  • CI had not run on this pull request because first-time contributions wait
    for my approval. I have approved it now, so it will report the same
    duplicate-name failure until the fix is pushed.

Your question about the other plugins

Please keep this pull request to Lineuparr for now. Stream-Mapparr,
Channel-Maparr and EPG-Janitor are separate projects with different lineup
handling, and I will decide separately whether and how they should get these
channels. There is no need to open pull requests there yet.

Once the duplicate is fixed and the aliases.py change is reduced to the new
sections, I will run the checks again and merge.

@taos15

taos15 commented Sep 25, 2026

Copy link
Copy Markdown
Author

Hi,

  • I will redo the formatting, python black auto-formates the document.

  • for the source ai mentioned the name of the page and the query to put in the search, but I will change it to the actual link to the post

  • I will check again the altice CNN, ai know that lineup has duplicated channels for HD and SD; and I did not want to change anything, that is why I created the combined one where I curated using the USA combined as the base.

@PiratesIRC

Copy link
Copy Markdown
Owner

Thanks, that all sounds good, and a direct link in source is better than what I asked for. On the Altice file: keeping the provider's list as published is the right instinct, but it still has to pass the validator on its own, because someone can pick that file instead of the combined one. If 28 and 37 really are the same channel, keep one; if one of them is actually CDN, rename it. I will re-run the checks when you push.

@taos15

taos15 commented Sep 25, 2026 •

Copy link
Copy Markdown
Author

I will update the files over the weekend, it in the meantime here are the links:

altice DO

claro DO

Regarding DO channel 28 and 37; the source have them duplicate, bit I know for a fact that 37 is CDN 37 (Cadena de Noticias)

I found this other source. This one look like a first party source, but I would need to cross reference the lineup with the original.

altice official DO

claro official DO not nicely formatted, but can be use to validate the 3rd party lineup post.

@PiratesIRC

Copy link
Copy Markdown
Owner

Hi, just checking in on this one. Are you still planning to push the updated files? The only thing failing CI is the duplicate CDN SportsMax in Nacionales of DO_Altice_lineup.json; since you confirmed 37 is CDN (Cadena de Noticias), renaming that entry should make the check pass. Thanks also for the official Altice and Claro links. No rush, I just did not want this to sit without a reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants