Conversation
…efix
Category Detail = "None - single group (prefix only, no categories)" built
its group name through the same path as every other category, giving
"<prefix>: All" instead of the prefix alone the setting's description
promises. Fixed in _make_group_name, the one helper all ~10 callers share,
so cleanup, stream re-sort and group lookup all agree on the new name too.
Two edge cases handled per the issue discussion: a prefix with no channels
still needs a name ("All", unchanged), and a prefix already ending in a
separator (e.g. "DTV-") must not leave it dangling ("DTV", not "DTV-All").
Also migrates an existing "<prefix>: All" group (from before this fix) to
the new "<prefix>" name in place, preserving its id and channel
assignments, rather than leaving it as an orphaned duplicate next to a
freshly created "<prefix>" group. If both already exist, both are left
alone and a warning is logged instead of merging channels silently.
Fixes PiratesIRC#30
sbcrumb
force-pushed
the
fix/prefix-only-group-name
branch
from
September 27, 2026 18:32
c1c7220 to
239eeef
Compare
sbcrumb
marked this pull request as ready for review
September 27, 2026 18:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<prefix>: Allinstead of just<prefix>._make_group_name, the single helper every caller (group sync, channel sync, cleanup, stream re-sort, etc.) goes through, so they all agree on the new name.All, and a prefix already ending in a separator (e.g.DTV-) no longer leaves it dangling (DTV, notDTV-All).<prefix>: Allgroups from before this fix are renamed in place on the next sync (preserving the group's id and its channels) rather than left behind as an orphaned duplicate next to a freshly created<prefix>group. If a<prefix>group already exists too, both are left alone and a warning is logged instead of merging channels silently.Test plan
pytest tests/— 1097 passed (21 new tests intests/test_group_prefix_only.py: sentinel handling, all documented_make_group_nameedge cases, regression coverage for Normal/Simple/Refined detail modes, and the migration helper's rename / both-exist-warn / dry-run / no-op / separator-terminated-prefix paths).github/scripts/validate_plugin.py.github/scripts/check_core_parity.py/check_client_parity.py/check_matcher_golden.py(untouched, confirming this change doesn't touch vendored/matching code)scripts/check_version_sync.pyruff check . --select E9,F63,F7,F82python -m py_compile Lineuparr/*.pyOpening as a draft since I'd like your read on the migration behavior (rename-in-place vs. warn-and-leave-both) before marking it ready.