fix(zones): a West channel no longer receives the unmarked East feed (#55) - #56
Merged
Merged
Conversation
…55) extract_zone reads an unmarked stream name as DEFAULT, which its own docstring calls the East feed, and the channel side already routes an unmarked channel as East. The stream side dropped only a stream literally marked EAST from a West channel, so the same feed was dropped when the provider wrote "(EAST)" and kept when it did not. Measured on the maintainer's box: STARZ (W) and Showtime (W) each held 6 unmarked rows beside their West feeds. - A West channel keeps West streams only; unmarked ranks with EAST. - When no West stream matched, Match and Assign (and Preview) leave a channel that already holds streams untouched in both Overwrite modes, and give the other-zone streams only to a channel holding none. - Sort keeps the keep-everything fallback, since it replaces the list. Fixes #55 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55.
What was wrong
extract_zonereads a stream name with no zone marker asDEFAULT, which its docstring calls the East feed in a US lineup, and the channel side already routes an unmarked channel as East._order_streams_for_zonedropped only a stream literally markedEASTfrom a West channel, so the same feed was dropped when writtenINVESTIGATION CHANNEL (EAST)and kept when writtenINVESTIGATION CHANNEL.Measured on the maintainer's install:
STARZ (W)held 3 West rows and 6 unmarked rows,Showtime (W)held 9 West rows and 6 unmarked rows.What changes
_zone_affinity_rankranks unmarked equal to East on a West channel._streams_to_assign:Tests
tests/test_issue_55_west_unmarked.py(13 tests), plus four existing tests rewritten because they asserted the old behaviour. Full suite: 1547 passed. Each guard was removed in turn and a named test failed each time; a comment-only change left the suite green.Effect on the maintainer's install once deployed
The daily Sort will remove the 12 unmarked rows from
STARZ (W)andShowtime (W); both keep their West streams. No other West channel is affected.🤖 Generated with Claude Code