Skip to content

Fix /pixelchat reload not applying config changes (API key, log level, language, ChatGuard state) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToothyDev merged 4 commits into from
May 12, 2026
Merged

Fix /pixelchat reload not applying config changes (API key, log level, language, ChatGuard state) #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbb5eab
Initial plan
Copilot Mar 31, 2026
7496721
fix: ensure config reloads fully apply (API key, log level, and more)
Copilot Mar 31, 2026
30a3a78
Merge branch 'master' into copilot/fix-config-reload-issue
ToothyDev May 8, 2026
dedaef1
refactor: resolve language ConfigHelper as local variable per method …
Copilot May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions src/main/java/de/pixelmindmc/pixelchat/PixelChat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,36 @@ private void loadConfigs() {
}
}

/**
* Reloads all plugin configurations and re-initializes dependent components
*/
public void reloadPlugin() {
getLoggingHelper().debug("Reloading plugin");

// Reload all configuration files
configHelper.loadConfig();
configHelperPlayerStrikes.loadConfig();
configHelperEmojiList.loadConfig();
configHelperChatCodesList.loadConfig();
configHelperLangCustom.loadConfig();
configHelperLangGerman.loadConfig();
configHelperLangEnglish.loadConfig();
configHelperLangSpanish.loadConfig();
configHelperLangFrench.loadConfig();
configHelperLangDutch.loadConfig();
configHelperLangSimplifiedChinese.loadConfig();
configHelperLangTraditionalChinese.loadConfig();

// Update the log level from the reloaded config
loggingHelper.setLogLevel(getConfigHelper().getString(ConfigConstants.General.LOG_LEVEL));

// Re-initialize the API helper so new API key / endpoint / model values take effect
registerAPIHelper();

// Re-initialize the ChatGuard helper so it picks up the refreshed language config
registerChatGuardHelper();
}

/**
* Retrieves the plugin configuration
*
Expand Down Expand Up @@ -229,12 +259,14 @@ private void registerAPIHelper() {

// Check if the Chatguard module is active
if (!getConfigHelper().getBoolean(ConfigConstants.Modules.CHATGUARD)) {
apiHelper = null;
return;
}

// Check if the config file exists and API key is either unset or still at its default value
if (apiKey.isEmpty() || getConfigHelper().getFileExist() && Objects.equals(apiKey, "API-KEY")) {
getLoggingHelper().warning(getConfigHelperLanguage().getString(LangConstants.Global.NO_API_KEY_SET));
apiHelper = null;
return;
}

Expand Down
17 changes: 11 additions & 6 deletions src/main/java/de/pixelmindmc/pixelchat/commands/PixelChatCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public class PixelChatCommand implements CommandExecutor {
private final @NotNull LoggingHelper loggingHelper;
private final @NotNull ConfigHelper configHelper;
private final @NotNull ConfigHelper configHelperPlayerStrikes;
private final @NotNull ConfigHelper configHelperLanguage;

/**
* Constructs a PixelChatCommand object
Expand All @@ -59,7 +58,6 @@ public PixelChatCommand(@NotNull PixelChat plugin) {
this.loggingHelper = plugin.getLoggingHelper();
this.configHelper = plugin.getConfigHelper();
this.configHelperPlayerStrikes = plugin.getConfigHelperPlayerStrikes();
this.configHelperLanguage = plugin.getConfigHelperLanguage();

@Gaming12846 Gaming12846 May 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the variable and get the ConfigHelper from the plugin every single time?

@ToothyDev ToothyDev May 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Explore whether another pattern is more fitting here, and apply it to the other changed files as well. Using the getter every single time isn't ideal and quite verbose

Copilot AI May 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in commit dedaef1. Instead of removing the field and scattering plugin.getConfigHelperLanguage() calls throughout each method, each method that needs the language config now resolves it once into a local variable at the top (ConfigHelper configHelperLanguage = plugin.getConfigHelperLanguage()). This keeps the code as readable as a field reference while ensuring it always picks up the current language setting after a reload.

}

/**
Expand All @@ -73,6 +71,8 @@ public PixelChatCommand(@NotNull PixelChat plugin) {
*/
@Override
public boolean onCommand(@NotNull CommandSender sender, @NotNull Command command, @NotNull String label, @NotNull String @NotNull [] args) {
ConfigHelper configHelperLanguage = plugin.getConfigHelperLanguage();

// Display usage information if no arguments are provided
if (args.length == 0) {
sender.sendMessage(LangConstants.PLUGIN_PREFIX + ChatColor.RED + configHelperLanguage.getString(LangConstants.Global.INVALID_SYNTAX) + " " + ChatColor.RESET + configHelperLanguage.getString(LangConstants.Global.INVALID_SYNTAX_USAGE) + label + " <version|reload>");
Expand All @@ -99,6 +99,8 @@ public boolean onCommand(@NotNull CommandSender sender, @NotNull Command command
* @param args The arguments
*/
private void handleVersionSubcommand(@NotNull CommandSender sender, @NotNull String label, @NotNull String @NotNull [] args) {
ConfigHelper configHelperLanguage = plugin.getConfigHelperLanguage();

// Check if the player has the required permission
if (!sender.hasPermission(PermissionConstants.Commands.VERSION) && sender.hasPermission(PermissionConstants.Commands.RELOAD) && !sender.hasPermission(PermissionConstants.Commands.VERSION) && !sender.hasPermission(PermissionConstants.Commands.VERSION)) {
sender.sendMessage(ChatColor.RED + configHelperLanguage.getString(LangConstants.Global.NO_PERMISSION));
Expand Down Expand Up @@ -144,6 +146,8 @@ private void handleVersionSubcommand(@NotNull CommandSender sender, @NotNull Str
* @param args The arguments
*/
private void handleReloadSubcommand(@NotNull CommandSender sender, @NotNull String label, @NotNull String @NotNull [] args) {
ConfigHelper configHelperLanguage = plugin.getConfigHelperLanguage();

// Check if the player has the required permission
if (!sender.hasPermission(PermissionConstants.Commands.RELOAD)) {
sender.sendMessage(ChatColor.RED + configHelperLanguage.getString(LangConstants.Global.NO_PERMISSION));
Expand All @@ -158,14 +162,15 @@ private void handleReloadSubcommand(@NotNull CommandSender sender, @NotNull Stri
return;
}

// Reload the plugin configurations
configHelper.loadConfig();
configHelperPlayerStrikes.loadConfig();
configHelperLanguage.loadConfig();
// Reload all plugin configurations and re-initialize dependent components
plugin.reloadPlugin();

// Debug logger message
loggingHelper.debug("Configuration files successfully reloaded");

// Re-resolve after reload in case the configured language changed
configHelperLanguage = plugin.getConfigHelperLanguage();

// Send a message after successfully reloading the configurations
sender.sendMessage(LangConstants.PLUGIN_PREFIX + ChatColor.GREEN + configHelperLanguage.getString(LangConstants.PixelChatCommand.RELOAD));
}
Expand Down
10 changes: 2 additions & 8 deletions src/main/java/de/pixelmindmc/pixelchat/listener/AsyncPlayerChatListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ public class AsyncPlayerChatListener implements Listener {
private final @NotNull LoggingHelper loggingHelper;
private final @NotNull ConfigHelper configHelper;
private final @NotNull ChatGuardHelper chatGuardHelper;
private boolean chatGuardEnabled = false;
private boolean emojiEnabled = false;
private boolean chatCodesEnabled = false;

Expand All @@ -66,13 +65,8 @@ public AsyncPlayerChatListener(@NotNull PixelChat plugin) {
@NotNull ConfigHelper configHelperEmojiList = plugin.getConfigHelperEmojiList();
@NotNull ConfigHelper configHelperChatCodesList = plugin.getConfigHelperChatCodesList();

// Chatguard module
if (plugin.getAPIHelper() != null) {
this.chatGuardEnabled = true;
}

// Initialize CarbonChat integration if available
if (chatGuardEnabled && configHelper.getBoolean(ConfigConstants.PluginSupport.CARBONCHAT) && setupCarbonChatIntegration()) {
if (plugin.getAPIHelper() != null && configHelper.getBoolean(ConfigConstants.PluginSupport.CARBONCHAT) && setupCarbonChatIntegration()) {
carbonChatIntegration.registerCarbonChatListener();
}

Expand Down Expand Up @@ -121,7 +115,7 @@ private void onAsyncPlayerChat(@NotNull AsyncPlayerChatEvent event) {
boolean chatGuardMessageBlocked = false;

// AI based chat guard module
if (chatGuardEnabled && carbonChatIntegration == null && !player.hasPermission(PermissionConstants.Moderation.BYPASS_CHAT_MODERATION)) {
if (plugin.getAPIHelper() != null && carbonChatIntegration == null && !player.hasPermission(PermissionConstants.Moderation.BYPASS_CHAT_MODERATION)) {
chatGuardMessageBlocked = checkIfMessageShouldBeBlocked(event, message, player);
}

Expand Down
18 changes: 4 additions & 14 deletions src/main/java/de/pixelmindmc/pixelchat/utils/APIHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,6 @@ public class APIHelper {
private final @NotNull LoggingHelper loggingHelper;
private final @NotNull ConfigHelper configHelper;

private final String aiModel;
private final String apiUrl;
private final String apiKey;
private final String sysPrompt;

/**
* Constructs a APIHelper object
*
Expand All @@ -58,11 +53,6 @@ public class APIHelper {
public APIHelper(@NotNull PixelChat plugin) {
this.loggingHelper = plugin.getLoggingHelper();
this.configHelper = plugin.getConfigHelper();

this.apiUrl = configHelper.getString(ConfigConstants.API.ENDPOINT);
this.aiModel = configHelper.getString(ConfigConstants.API.MODEL);
this.apiKey = configHelper.getString(ConfigConstants.API.KEY);
this.sysPrompt = configHelper.getString(ConfigConstants.API.SYSTEM_PROMPT);
}

/**
Expand Down Expand Up @@ -92,7 +82,7 @@ public APIHelper(@NotNull PixelChat plugin) {
} catch (IOException e) {
throw new MessageClassificationException("Failed to classify message due to an IO issue.", e);
} catch (URISyntaxException e) {
throw new MessageClassificationException("Failed to classify message: invalid API endpoint URL '" + apiUrl + "'", e);
throw new MessageClassificationException("Failed to classify message: invalid API endpoint URL '" + configHelper.getString(ConfigConstants.API.ENDPOINT) + "'", e);
} catch (Exception e) {
throw new MessageClassificationException("Failed to classify message due to an unexpected error.", e);
}
Expand All @@ -106,11 +96,11 @@ public APIHelper(@NotNull PixelChat plugin) {
* @throws URISyntaxException Thrown if the set API URL isn't valid
*/
private @NotNull HttpURLConnection createConnection() throws IOException, URISyntaxException {
URL url = new URI(apiUrl).toURL();
URL url = new URI(configHelper.getString(ConfigConstants.API.ENDPOINT)).toURL();
HttpURLConnection connection = (HttpURLConnection) url.openConnection();
connection.setRequestMethod("POST");
connection.setRequestProperty("Content-Type", "application/json");
connection.setRequestProperty("Authorization", "Bearer " + apiKey);
connection.setRequestProperty("Authorization", "Bearer " + configHelper.getString(ConfigConstants.API.KEY));
connection.setDoOutput(true);

return connection;
Expand All @@ -124,7 +114,7 @@ public APIHelper(@NotNull PixelChat plugin) {
* @throws IOException If any issue happens, an exception is thrown
*/
private void sendRequest(@NotNull HttpURLConnection connection, @NotNull String message) throws IOException {
Map<String, Object> json = Map.of("model", aiModel, "messages", new Map[]{Map.of("role", "system", APIConstants.General.CONTENT, sysPrompt + "Language: " + configHelper.getString(ConfigConstants.General.LANGUAGE)), Map.of("role", "user", APIConstants.General.CONTENT, message)}, "response_format", Map.of("type", "json_object"));
Map<String, Object> json = Map.of("model", configHelper.getString(ConfigConstants.API.MODEL), "messages", new Map[]{Map.of("role", "system", APIConstants.General.CONTENT, configHelper.getString(ConfigConstants.API.SYSTEM_PROMPT) + "Language: " + configHelper.getString(ConfigConstants.General.LANGUAGE)), Map.of("role", "user", APIConstants.General.CONTENT, message)}, "response_format", Map.of("type", "json_object"));

String jsonInputString = new Gson().toJson(json);

Expand Down
8 changes: 4 additions & 4 deletions src/main/java/de/pixelmindmc/pixelchat/utils/ChatGuardHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ public class ChatGuardHelper {
private final @NotNull PixelChat plugin;
private final @NotNull LoggingHelper loggingHelper;
private final @NotNull ConfigHelper configHelper;
private final @NotNull ConfigHelper configHelperLanguage;

/**
* Constructs a ChatGuardHelper object
Expand All @@ -48,7 +47,6 @@ public ChatGuardHelper(@NotNull PixelChat plugin) {
this.plugin = plugin;
this.loggingHelper = plugin.getLoggingHelper();
this.configHelper = plugin.getConfigHelper();
this.configHelperLanguage = plugin.getConfigHelperLanguage();
}

/**
Expand All @@ -60,6 +58,7 @@ public ChatGuardHelper(@NotNull PixelChat plugin) {
* @param blockOrCensor Whether the message should be blocked ({@code true}) or censored ({@code false})
*/
public void notifyAndStrikePlayer(@NotNull Player player, @NotNull String userMessage, @NotNull MessageClassification classification, boolean blockOrCensor) {
ConfigHelper configHelperLanguage = plugin.getConfigHelperLanguage();
String chatGuardPrefix = (configHelper.getBoolean(ConfigConstants.ChatGuard.CustomPrefix.ENABLED) ? configHelper.getString(ConfigConstants.ChatGuard.CustomPrefix.FORMAT) + ChatColor.RESET + " " : LangConstants.PLUGIN_PREFIX);

// Notify player if enabled
Expand Down Expand Up @@ -113,6 +112,7 @@ public void runStrikeSystem(@NotNull UUID playerUUID, @NotNull String playerName
// Debug logger message
loggingHelper.debug("Run strike system on " + playerName);

ConfigHelper configHelperLanguage = plugin.getConfigHelperLanguage();
ConfigHelper configHelperPlayerStrikes = plugin.getConfigHelperPlayerStrikes();
String action = "NOTHING";

Expand All @@ -134,11 +134,11 @@ public void runStrikeSystem(@NotNull UUID playerUUID, @NotNull String playerName
action = "KICK";
} else if (strikes >= strikesToTempBan && strikes < strikesToBan) {
// Player has enough strikes to be temporarily banned
executeCommand(plugin.getConfigHelper().getString(ConfigConstants.ChatGuard.StrikeSystem.Commands.TEMP_BAN), playerName, configHelperLanguage.getString(LangConstants.ChatGuard.Player.BAN_TEMPORARY) + " " + reason);
executeCommand(configHelper.getString(ConfigConstants.ChatGuard.StrikeSystem.Commands.TEMP_BAN), playerName, configHelperLanguage.getString(LangConstants.ChatGuard.Player.BAN_TEMPORARY) + " " + reason);
action = "TEMP-BAN";
} else if (strikes >= strikesToBan) {
// Player has enough strikes to be permanently banned
executeCommand(plugin.getConfigHelper().getString(ConfigConstants.ChatGuard.StrikeSystem.Commands.BAN), playerName, configHelperLanguage.getString(LangConstants.ChatGuard.Player.BAN_PERMANENT) + " " + reason);
executeCommand(configHelper.getString(ConfigConstants.ChatGuard.StrikeSystem.Commands.BAN), playerName, configHelperLanguage.getString(LangConstants.ChatGuard.Player.BAN_PERMANENT) + " " + reason);
action = "BAN";
}

Expand Down
Loading