Fix denoise bug#90
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an NA/median issue in the denoising isotype reduction component and adds in-report deep-linking for plot tabsets, including client-side hash navigation to open nested tabs and refresh widgets/tables when navigating via #... anchors.
Changes:
- Add stable, URL-safe plot anchor IDs to
title_plotlist(),tabset_plotlist(), andtabset_nested_plotlist()(with corresponding tests/docs/CSS). - Add hash-based navigation logic in
inst/quarto/custom.htmlto activate nested tab-pane chains, scroll to targets, and refresh HTMLWidgets/DataTables/tooltips. - Fix
component_denoisingisotype reduction handling by convertingNAreductions to0(and tweak plot rounding).
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/testthat/test_plot_helpers.R |
Updates existing expectations to disable anchors in tests and adds new tests for slug/anchor emission. |
R/read_data.R |
Tightens control_markers assertion in downsample_data(). |
R/plot_helpers.R |
Implements anchor slugging + optional anchor emission for plot lists/tabsets. |
R/components.R |
Fixes NA handling for isotype reduction and adjusts rounding. |
man/title_plotlist.Rd |
Documents new anchor_prefix argument. |
man/tabset_plotlist.Rd |
Documents new anchor_prefix argument. |
man/tabset_nested_plotlist.Rd |
Documents new anchor_prefix argument. |
inst/quarto/styles.css |
Adds .plot-anchor styling (zero-height anchor div). |
inst/quarto/custom.html |
Reworks tabset behavior and adds hash/deeplink navigation + widget/table refresh. |
CHANGELOG.md |
Records added deep-linking/navigation and denoise/tab activation fixes. |
Files not reviewed (3)
- man/tabset_nested_plotlist.Rd: Generated file
- man/tabset_plotlist.Rd: Generated file
- man/title_plotlist.Rd: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ludvigla
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a plot bug and added tabset anchors that can be used to navigate throughout the ES using links.
Added
title_plotlist,tabset_plotlist,tabset_nested_plotlist). Anchor IDs are derived from the knitr chunk label and tab name (e.g.#abundance-per-marker-cd3,#qc-metrics-sequencing-saturation-s11).custom.html: opens nested tab panes for#links, scrolls to the target, refreshes HTMLWidgets and DataTables in newly shown tabs, and restores tab/scroll state on browser back.Fixed
component_denoisingin the isotype reduction plot, where components with zero isotype counts would cause the summary median to becomeNAs.Type of change
How Has This Been Tested?
Manual tests.
PR checklist: