Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an opt-in mechanism to retain full per-cell metadata when loading PNA PXL files into Seurat, while defaulting to a curated subset of QC-relevant columns to keep meta.data smaller/cleaner (Fixes: PNA-2926).
Changes:
- Added
detailed_meta_dataargument toReadPNA_Seurat(); whenFALSEit filtersmeta.datatoCELL_META_COLS. - Introduced
CELL_META_COLSas a central definition of which cell metadata columns are retained by default. - Updated documentation, changelog, and added a test to cover the new behavior.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
R/load_data_pna.R |
Adds detailed_meta_data parameter, validates it, and filters cell metadata by default. |
R/aaa.R |
Defines CELL_META_COLS constant used for default metadata filtering. |
tests/testthat/test-ReadPNA_Seurat.R |
Adds a test asserting detailed metadata loads more columns than the default. |
man/ReadPNA_Seurat.Rd |
Documents the new detailed_meta_data argument. |
CHANGELOG.md |
Notes the new default metadata filtering behavior and how to opt into detailed metadata. |
Files not reviewed (1)
- man/ReadPNA_Seurat.Rd: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maxkarlsson
requested changes
Jun 22, 2026
maxkarlsson
left a comment
Contributor
There was a problem hiding this comment.
I think we should drop tau!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a meta data filter to
ReadPNA_Seuratto keep the meta.data slot clean. Full meta data can be obtained by settingdetailed_meta_data = TRUE.The columns to keep are defined in the
CELL_META_COLSvariable. Currently, these are:Fixes: PNA-3078
Type of change
How Has This Been Tested?
Added new test to
tests/testthat/test-ReadPNA_Seurat.RPR checklist: